Page MenuHomePhabricator

DiscussionTools and LiquidThreads don’t get along
Closed, ResolvedPublicBUG REPORT

Description

Scenario 1

Steps to reproduce

  1. Open https://hu.wikipedia.org/wiki/Szerkeszt%C5%91vita:Teszt_Elem%C3%A9r. Please note that this is a test user, so you may play with the page as you wish.

Actual result

  1. The talk page empty state experience (T270323) appears.

Expected result

  1. The talk page empty state experience doesn’t appear. LiquidThreads should handle starting discussions.

Scenario 2

Steps to reproduce

  1. On the above page, click the new topic tab (the one added by the skin, not the ones added by LQT and DiscussionTools).

Actual result

  1. Both the LQT and the DiscussionTools new topic experience appears. The DiscussionTools one appears within the last LQT thread; its topic field appears two more times.

Screenshot 2023-02-11 at 14-21-12 Szerkesztővita Teszt Elemér - Wikipédia.png (1×1 px, 177 KB)

Expected result

  1. DiscussionTools doesn’t do anything. It’s a LQT talk page, none of DiscussionTools’ business.

Other information

The page I used in this bug report is on huwiki, but it’s more visible on translatewiki.net, which recently enabled DiscussionTools, but still extensively uses LQT (which was the default experience before).

Event Timeline

That’s funny, thanks for the report.

DiscussionTools should simply disable itself entirely on LiquidThreads pages, like it does on Flow pages, right?

ppelberg added a subscriber: ppelberg.

That’s funny, thanks for the report.

+1 and I'd like to defer prioritizing work on how LiquidThreads and DiscussionTools interact.

Reason: I wonder if projects will, like translatewiki.net [i], soon favor deprecating LiquidThreads entirely.


i. https://translatewiki.net/wiki/Thread:Support/Replacing_the_discussion_system

Well, it took me only 10 minutes to figure out how to do it… I think it might help the deprecation if the migration is more seamless.

Change 888809 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Disable on LiquidThreads pages

https://gerrit.wikimedia.org/r/888809

Well, it took me only 10 minutes to figure out how to do it… I think it might help the deprecation if the migration is more seamless.

Touché. Sounds good to me.

Change 888809 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Disable on LiquidThreads pages

https://gerrit.wikimedia.org/r/888809