Page MenuHomePhabricator

diffConfig no longer detecs any changes in operations/mediawiki-config.git
Closed, ResolvedPublic

Description

During today’s UTC afternoon backport+config window, I noticed that the diffConfig builds no longer report a diff (e.g. this build for this change, or this build for this change). It was still working two weeks ago in this older build.

Comparing the console output, it looks like one buildConfigCache.php run got lost:

old/working
++ /usr/bin/env
++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
> php -e tests/buildConfigCache.php
> git checkout -q HEAD~1
> git add -f tests/data/config-cache/
> php -e tests/buildConfigCache.php
> git diff -R --minimal --color --exit-code
[lots of diff output]
new/broken
++ /usr/bin/env
++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
> php multiversion/bin/manage-dblist 'update'
> git checkout -q HEAD~1
> git add -f tests/data/config-cache/
> php -e tests/buildConfigCache.php
> git diff -R --minimal --color --exit-code
> git reset tests/data/config-cache/

Without the first buildConfigCache.php, the git add command probably has no effect; the other buildConfigCache.php then only creates a bunch of untracked files, and git diff sees no changes to tracked files.

Event Timeline

Boldly making this High priority, since the config diff is quite useful when assessing changes to deploy. (IMHO this could even qualify for UBN, but I don’t want to go there yet.)

It looks like one buildConfigCache.php call was removed in multiversion: Create dblist-manage command for easy add/delete for T308932 – though I don’t fully understand that change, so it’s possible that the removal is correct and diffConfig is broken for a different reason. CCing @Krinkle and @Ladsgroup from that change.

I've also noticed this a few times this week. Def affects my config deployment confidence :)

Change 889562 had a related patch set uploaded (by Krinkle; author: Krinkle):

[operations/mediawiki-config@master] build: Restore 'buildConfigCache' call

https://gerrit.wikimedia.org/r/889562

Change 889562 merged by jenkins-bot:

[operations/mediawiki-config@master] build: Restore 'buildConfigCache' call

https://gerrit.wikimedia.org/r/889562