Page MenuHomePhabricator

Reply tool "Show 1 new comment" button causes the tool to disappear, doesn't show new comments
Closed, ResolvedPublic

Description

Reply tool "Show 1 new comment" (or "Show N new comments") button causes the tool to disappear, doesn't show new comments.

Exception is thrown, e.g.:

Uncaught Error: No infusion data found: ooui-php-193
    at OO.ui.Element.static.unsafeInfuse
    at OO.ui.Element.static.infuse
    at OO.ui.infuse
    at ReplyLinksController.js.ReplyLinksController.clearActiveLink
    at ReplyLinksController.js.ReplyLinksController.teardown
    at Object.init
    at reallyInit
    at mw.dt.init
    at Object.add
    at updatePageContents

It's unclear to me whether this is related to T329299. The symptoms seem different. @Esanders noticed this one.

Caused by the work on T317035 (06919f94449d01d87725947aa04f2017e6dc0ac0).

Event Timeline

Change 888713 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] ReplyLinksController: Fix teardown failing when reloading

https://gerrit.wikimedia.org/r/888713

Change 888713 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ReplyLinksController: Fix teardown failing when reloading

https://gerrit.wikimedia.org/r/888713

Change 888768 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.22] ReplyLinksController: Fix teardown failing when reloading

https://gerrit.wikimedia.org/r/888768

Change 888768 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.22] ReplyLinksController: Fix teardown failing when reloading

https://gerrit.wikimedia.org/r/888768

Mentioned in SAL (#wikimedia-operations) [2023-02-13T21:26:19Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:888768|ReplyLinksController: Fix teardown failing when reloading (T329523)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-13T21:27:56Z] <taavi@deploy1002> taavi and matmarex: Backport for [[gerrit:888768|ReplyLinksController: Fix teardown failing when reloading (T329523)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-13T21:34:57Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:888768|ReplyLinksController: Fix teardown failing when reloading (T329523)]] (duration: 08m 38s)

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Ryasmeen edited projects, added Verified; removed Editing QA.