Release a new version of Timestamp
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Feb 14 2023, 12:56 AM

Description

As part of r884063 (part of Growth-Positive-Reinforcement, an ongoing Growth-Team project), being able to do ConvertibleTimestamp::time()->sub(...) would come useful (added in 09b22e4600). Let's do a new release of the library, which would include the following patches:

as well as some require-dev bumps by libraryupgrader. AFAICS, there is no breaking change involved, merely new methods/new optional parameters => let's go for 4.1.0 as the new version.

Details

Subject	Repo	Branch	Lines +/-
Release v4.1.0	mediawiki/libs/Timestamp	master	+6 -0
Bump wikimedia/timestamp to 4.1.0	mediawiki/extensions/Wikibase	master	+2 -2
Bump wikimedia/timestamp to 4.1.0	mediawiki/libs/metrics-platform	master	+17 -16
Update ConvertibleTimestamp to 4.1.0	mediawiki/core	master	+2 -1
Update ConvertibleTimestamp to 4.1.0	mediawiki/vendor	master	+144 -44
Do not cast fake time callable to int	mediawiki/libs/Timestamp	master	+9 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Urbanecm_WMF	T329594 Release a new version of Timestamp
		Resolved		Urbanecm_WMF	T329609 ApiQueryLanguageInfoTest uses ConvertibleTimestamp::setFakeTime incorrectly

Event Timeline

Urbanecm_WMF created this task.Feb 14 2023, 12:56 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptFeb 14 2023, 12:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Urbanecm_WMF updated the task description. (Show Details)Feb 14 2023, 12:58 AM

Change 888820 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/libs/Timestamp@master] Release v4.1.0

https://gerrit.wikimedia.org/r/888820

gerritbot added a project: Patch-For-Review.Feb 14 2023, 12:59 AM

Change 888820 merged by jenkins-bot:

[mediawiki/libs/Timestamp@master] Release v4.1.0

https://gerrit.wikimedia.org/r/888820

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2023, 1:10 AM

Change 888825 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/vendor@master] Update ConvertibleTimestamp to 4.1.0

https://gerrit.wikimedia.org/r/888825

Change 888826 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Update ConvertibleTimestamp to 4.1.0

https://gerrit.wikimedia.org/r/888826

Change 889064 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/libs/Timestamp@master] Do not cast fake time callable to int

https://gerrit.wikimedia.org/r/889064

Urbanecm_WMF added a subtask: T329609: ApiQueryLanguageInfoTest uses ConvertibleTimestamp::setFakeTime incorrectly.Feb 14 2023, 9:14 AM

Change 889064 abandoned by Urbanecm:

[mediawiki/libs/Timestamp@master] Do not cast fake time callable to int

Reason:

replaced with I82d49a5e3a52c14dbd7e5324eb4c75cf7c33f3d2

https://gerrit.wikimedia.org/r/889064

Note that similar setMockTime methods such as on BagOStuff and WANObjectCache accept a by-ref microtime-like float. This could potentially be applied to Timestamp as well, with the value casted to int by the internal consumer within the Timestamp library when it needs a whole second value.

On the other hand, I actually quite like the strictness of permitting whole integers only since indeed almost everything we do in MW is only sensitive to expiry dates or formatted timestamps, both of which utilize whole seconds only. And with clockskew etc it seems rather questionable anyway to rely on milliseconds for unit test correctness.

Lucas_Werkmeister_WMDE closed subtask T329609: ApiQueryLanguageInfoTest uses ConvertibleTimestamp::setFakeTime incorrectly as Resolved.Feb 14 2023, 1:18 PM

Change 888825 merged by jenkins-bot:

[mediawiki/vendor@master] Update ConvertibleTimestamp to 4.1.0

https://gerrit.wikimedia.org/r/888825

Change 888826 merged by jenkins-bot:

[mediawiki/core@master] Update ConvertibleTimestamp to 4.1.0

https://gerrit.wikimedia.org/r/888826

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 2:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 16 2023, 3:00 AM

Uses that should be bumped:

Extension:Wikibase
- lib/packages/wikibase/changes/composer.json (1 matches)
mediawiki/libs/metrics-platform
- composer.json (1 matches)

larissagaulia moved this task from Inbox, needs triage to Radar on the Performance-Team board.Feb 20 2023, 7:46 PM

larissagaulia edited projects, added Performance-Team (Radar); removed Performance-Team.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Feb 20 2023, 8:12 PM

Ottomata mentioned this in T340067: EventBus should set dt fields with greater precision than second.Jun 26 2023, 7:25 PM

Krinkle removed projects: Performance-Team (Radar), MediaWiki-General.Aug 6 2023, 10:32 PM

Krinkle unsubscribed.

Change 954082 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/Wikibase@master] Bump wikimedia/timestamp to 4.1.0

https://gerrit.wikimedia.org/r/954082

gerritbot added a project: Patch-For-Review.Aug 31 2023, 3:30 PM

Urbanecm_WMF closed this task as Resolved.Aug 31 2023, 3:35 PM

Use in mediawiki/libs/metrics-platform remains unpatched.

Change 954100 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/libs/metrics-platform@master] Bump wikimedia/timestamp to 4.1.0

https://gerrit.wikimedia.org/r/954100

In T329594#9134839, @Jdforrester-WMF wrote:

Use in mediawiki/libs/metrics-platform remains unpatched.

Not as a result of this library release though: it currently requires 3.0.0, even though 4.0.0 was released in Mar 2022, almost a year before my Feb 2023 release. Uploaded a bumping patch though.

In T329594#9134853, @Urbanecm_WMF wrote:

In T329594#9134839, @Jdforrester-WMF wrote:

Use in mediawiki/libs/metrics-platform remains unpatched.

Not as a result of this library release though: it currently requires 3.0.0, even though 4.0.0 was released in Mar 2022, almost a year before my Feb 2023 release. Uploaded a bumping patch though.

Hmm, yes, EventLogging is using v2.0.0 which is from February. Not sure how this doesn't fatal currently?

In T329594#9135029, @Jdforrester-WMF wrote:

Hmm, yes, EventLogging is using v2.0.0 which is from February. Not sure how this doesn't fatal currently?

That's wikimedia/metrics-platform, not timestamp, and it appears to be the newest available release? Why should it fatal?

In T329594#9135098, @Urbanecm_WMF wrote:

In T329594#9135029, @Jdforrester-WMF wrote:

Hmm, yes, EventLogging is using v2.0.0 which is from February. Not sure how this doesn't fatal currently?

That's wikimedia/metrics-platform, not timestamp, and it appears to be the newest available release? Why should it fatal?

EL is depending on a library which requires Timestamp 3.x but in production it's loaded alongside Timestamp 4.x and /vendor doesn't complain about mis-matched dependencies?

Change 954100 merged by jenkins-bot:

[mediawiki/libs/metrics-platform@master] Bump wikimedia/timestamp to 4.1.0

https://gerrit.wikimedia.org/r/954100

Change 954082 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Bump wikimedia/timestamp to 4.1.0

https://gerrit.wikimedia.org/r/954082

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2023, 11:30 AM

Urbanecm_WMF closed this task as Resolved.Sep 4 2023, 12:01 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 4 2023, 1:00 PM

Arlolra mentioned this in T345701: Wikimedia\Timestamp\TimestampException: Wikimedia\Timestamp\ConvertibleTimestamp::setTimestamp: Invalid timestamp format..Sep 27 2023, 8:27 PM