Page MenuHomePhabricator

Optimize permalinks maintenance script to avoid listing non-discussion pages
Closed, ResolvedPublic

Description

The biggest reason it took this long was that the script checked every page before actually doing anything on talk pages, it could have been made much faster but we learned about this quite late in the run. It's fine. Given that wikidata and commons are done now, I assume it won't be a big issue in other runs but still better to be fixed.

Event Timeline

Change 889140 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889140

Change 889140 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889140

Change 889267 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.22] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889267

Change 889268 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.23] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889268

Change 889267 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.22] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889267

Change 889268 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.23] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889268

Mentioned in SAL (#wikimedia-operations) [2023-02-15T14:11:53Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:889267|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]], [[gerrit:889268|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-15T14:13:45Z] <samtar@deploy1002> matmarex and samtar: Backport for [[gerrit:889267|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]], [[gerrit:889268|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-15T14:19:28Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:889267|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]], [[gerrit:889268|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]] (duration: 07m 34s)