Page MenuHomePhabricator
Create Task
Maniphest T329690

PHP Notice: Trying to access array offset on value of type null (in MediaWikiTitleCodec.php)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to access array offset on value of type null
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.22/includes/title/MediaWikiTitleCodec.php(561)
#0 /srv/mediawiki/php-1.40.0-wmf.22/includes/title/MediaWikiTitleCodec.php(561): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.22/includes/title/MediaWikiTitleCodec.php(191): MediaWikiTitleCodec->splitTitleString(string, integer)
#2 /srv/mediawiki/php-1.40.0-wmf.22/includes/user/UserNameUtils.php(300): MediaWikiTitleCodec->parseTitle(string, integer)
#3 /srv/mediawiki/php-1.40.0-wmf.22/includes/user/ActorStore.php(600): MediaWiki\User\UserNameUtils->getCanonical(string)
#4 /srv/mediawiki/php-1.40.0-wmf.22/includes/user/ActorStore.php(228): MediaWiki\User\ActorStore->normalizeUserName(string)
#5 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/Skin.php(523): MediaWiki\User\ActorStore->getUserIdentityByName(string)
#6 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/Skin.php(1331): Skin->getRelevantUser()
#7 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/Skin.php(1490): Skin->buildNavUrls()
#8 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/SkinTemplate.php(651): Skin->buildSidebar()
#9 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/SkinTemplate.php(186): SkinTemplate->getPortletsTemplateData()
#10 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/SkinMustache.php(88): SkinTemplate->getTemplateData()
#11 /srv/mediawiki/php-1.40.0-wmf.22/skins/Vector/includes/SkinVectorLegacy.php(161): SkinMustache->getTemplateData()
#12 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/SkinMustache.php(58): MediaWiki\Skins\Vector\SkinVectorLegacy->getTemplateData()
#13 /srv/mediawiki/php-1.40.0-wmf.22/includes/skins/SkinTemplate.php(179): SkinMustache->generateHTML()
#14 /srv/mediawiki/php-1.40.0-wmf.22/includes/OutputPage.php(2896): SkinTemplate->outputPage()
#15 /srv/mediawiki/php-1.40.0-wmf.22/includes/MediaWiki.php(935): OutputPage->output(boolean)
#16 /srv/mediawiki/php-1.40.0-wmf.22/includes/MediaWiki.php(573): MediaWiki->main()
#17 /srv/mediawiki/php-1.40.0-wmf.22/index.php(50): MediaWiki->run()
#18 /srv/mediawiki/php-1.40.0-wmf.22/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
Impact
Notes

Details

Request URL
https://ca.wiktionary.org/wiki/Special:Whatlinkshere/Usuari:c:/windows/win.ini//
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.18.0-a3mediawiki/vendormaster+112 -71
Title.php: bring closer to MediaWikiTitleCodec; allow colons in Talk titlesmediawiki/services/parsoidmaster+68 -31
Title.php: Handle user name equal to interwiki prefix in TitleParsermediawiki/services/parsoidmaster+4 -2
title: Handle user name equal to interwiki prefix in TitleParsermediawiki/coremaster+5 -3
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Feb 15 2023, 12:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2023, 12:20 AM
Krinkle moved this task from Untriaged to Feb 2023 on the Wikimedia-production-error board.Feb 15 2023, 12:20 AM
Umherirrender claimed this task.Feb 15 2023, 9:45 PM
Umherirrender subscribed.
		if ( $parts['namespace'] === NS_USER || $parts['namespace'] === NS_USER_TALK ) {
			$dbkey = IPUtils::sanitizeIP( $dbkey );
			// IPUtils::sanitizeIP return null only for bad input
			'@phan-var string $dbkey';
		}

		// Any remaining initial :s are illegal.
		if ( $dbkey !== '' && $dbkey[0] == ':' ) {	/*** <--  line 561 ***/
			$exception = ( $this->createMalformedTitleException )( 'title-invalid-leading-colon', $text );
			throw $exception;
		}

Happens for code Title::newFromText( 'C:', NS_USER ); when a interwiki C: exists

The C: is there after calling Title::getRootText on a (relevant) title of a user page in Skin::getRelevantUser. In that case the "subpage" part /windows/win.ini// is ignored and the C: is given into the validation. After stripping the interwiki C there is the empty string and IPUtils::sanitizeIP returns false there

gerritbot added a comment.Feb 15 2023, 10:01 PM

Change 889639 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] title: Handle user name equal to interwiki prefix in TitleParser

https://gerrit.wikimedia.org/r/889639

gerritbot added a project: Patch-For-Review.Feb 15 2023, 10:01 PM
Umherirrender added a comment.Feb 15 2023, 10:02 PM

Technial the same issue as T301487, because the namespace while parsing for an interwiki is not NS_MAIN

gerritbot added a comment.Feb 16 2023, 8:55 PM

Change 889639 merged by jenkins-bot:

[mediawiki/core@master] title: Handle user name equal to interwiki prefix in TitleParser

https://gerrit.wikimedia.org/r/889639

Umherirrender closed this task as Resolved.Feb 16 2023, 8:56 PM
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 16 2023, 9:00 PM
matmarex subscribed.Feb 16 2023, 10:15 PM
gerritbot added a comment.Mar 23 2023, 3:31 PM

Change 902419 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Title.php: Handle user name equal to interwiki prefix in TitleParser

https://gerrit.wikimedia.org/r/902419

gerritbot added a project: Patch-For-Review.Mar 23 2023, 3:31 PM
gerritbot added a comment.Mar 23 2023, 8:03 PM

Change 902465 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Title.php: bring closer to MediaWikiTitleCodec; allow colons in Talk titles

https://gerrit.wikimedia.org/r/902465

gerritbot added a comment.Mar 24 2023, 2:12 PM

Change 902419 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Title.php: Handle user name equal to interwiki prefix in TitleParser

https://gerrit.wikimedia.org/r/902419

gerritbot added a comment.Mar 24 2023, 4:55 PM

Change 902465 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Title.php: bring closer to MediaWikiTitleCodec; allow colons in Talk titles

https://gerrit.wikimedia.org/r/902465

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 5:10 PM
gerritbot added a comment.Mar 27 2023, 3:50 PM

Change 903292 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a3

https://gerrit.wikimedia.org/r/903292

gerritbot added a project: Patch-For-Review.Mar 27 2023, 3:50 PM
gerritbot added a comment.Mar 27 2023, 5:36 PM

Change 903292 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a3

https://gerrit.wikimedia.org/r/903292

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2023, 6:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits