Page MenuHomePhabricator

IP Masking (CommTech): TemplateWizard
Closed, ResolvedPublic

Description

This task is for tracking work to update the TemplateWizard extension ahead of IP Masking being enabled on WMF sites.

See T326816: Update features for temporary accounts, particularly What will be affected.

Event Timeline

TemplateWizard has only one place where it does something different for anonymous vs logged-in users, which is when it logs an event with EventLogging. It uses mw.user.isAnon() for this, which returns false for temp users, and so it doesn't look like any changes are required in order to confirm to IP Masking requirements.

Interestingly, TemplateData does a similar thing for tracking, but uses mw.user.getId() directly and without checking if the user is logged in — I suspect this is probably fine, because EventLogging treats an ID of 0 as anonymous anyway. So we might be able to simplify the code in TemplateWizard (but that doesn't really matter for the current task).

tl;dr: nothing to be done.

Should we close this? I haven't reviewed TemplateWizard in depth but will definitely take Sam's word for it that no changes are needed with respect to IP masking :)

Yep, let's call it done.

Change 1002573 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Do not track user ids of temporary accounts

https://gerrit.wikimedia.org/r/1002573

Change 1002573 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Do not track user ids of temporary accounts

https://gerrit.wikimedia.org/r/1002573