PendingTextInputWidget should be hidden if JavaScript is disabled in HTMLForm
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Feb 15 2023, 6:04 PM

Description

PendingTextInputWidget is used by TagMultiselectWidget and its children to display a widget in the loading state before the widget can be infused in JavaScript. However, if JavaScript is disabled or fails to load, the pending widget remains there, see screenshot:

The textarea is meant to be used as the input element if JS is not available, hence I believe the pending element should simply be hidden if JavaScript is not available (client-nojs).

(This task would need a mediawiki-widgets tag that doesn't exist. I hope HTMLForm and OOUI are close enough to let potentially interested people see this task)

Details

	Subject	Repo	Branch	Lines +/-
	htmlform: Load TagMultiselectWidget styles in more form fields	mediawiki/core	master	+6 -6
	Load TagMultiselectWidget styles in the HTMLForm fields that need them	mediawiki/core	master	+4 -0

Customize query in gerrit

Event Timeline

Daimona created this task.Feb 15 2023, 6:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2023, 6:04 PM

Mainframe98 awarded a token.Feb 15 2023, 6:07 PM

Can you give the use case? I saw the one in Special:Preferences works fine with styles from mw.widgets.TagMultiselectWidget.base.css

In T329780#8627405, @Func wrote:

Can you give the use case? I saw the one in Special:Preferences works fine with styles from mw.widgets.TagMultiselectWidget.base.css

Oh, you're right. I observed this behaviour on Special:EnableEventRegistration (CampaignEvents), which uses HTMLForm to generate the form (the patch that adds a UserMultiselectWidget is still in review though). In fact, the actual issue is that HTMLForm is not automatically loading the styles for the input.

Daimona renamed this task from PendingTextInputWidget should be hidden if JavaScript is disabled to PendingTextInputWidget should be hidden if JavaScript is disabled in HTMLForm.Feb 18 2023, 12:58 PM

Daimona removed a project: OOUI.

Change 890158 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Load TagMultiselectWidget styles in the HTMLForm fields that need them

https://gerrit.wikimedia.org/r/890158

gerritbot added a project: Patch-For-Review.Feb 18 2023, 1:00 PM

matmarex subscribed.Feb 19 2023, 2:08 AM

Change 890158 merged by jenkins-bot:

[mediawiki/core@master] Load TagMultiselectWidget styles in the HTMLForm fields that need them

https://gerrit.wikimedia.org/r/890158

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2023, 2:30 AM

matmarex closed this task as Resolved.Feb 19 2023, 2:35 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 19 2023, 3:00 AM

Change 890348 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] htmlform: Load TagMultiselectWidget styles in more form fields

https://gerrit.wikimedia.org/r/890348

gerritbot added a project: Patch-For-Review.Feb 20 2023, 12:05 PM

Change 890348 merged by jenkins-bot: