Page MenuHomePhabricator

Vopsbot doesn't have channel topic rights
Closed, ResolvedPublic

Description

When Vopsbot (irc nick sirenbot) restarts, it rejoins its channels but doesn't automatically recover its privileges. In the private SRE channel, that's not a factor, because anyone can update the topic. But in #wikimedia-operations and #wikimedia-sre, mode +t is set, so only ops and half-ops can update the topic. The bot is not automatically opped, so its topic updates fail, and the topic contains incorrect information about who's on call.

We can probably fix this either by configuring chanserv, or via ircservserv, but I don't have the rights to do so.

Event Timeline

legoktm opened https://gitlab.wikimedia.org/repos/sre/vopsbot/-/merge_requests/10

Use ChanServ to the change the topic to avoid needing to be opped

We can set the bot to be auto-opped (+O) if that's desired, but the general guidance is to be opped only when necessary (https://libera.chat/guides/catalyst#only-be-opped-up-when-necessary - really for humans but in practice we like bots to follow it too), which is why ircservserv has this complicated routine to op itself, do its business, and then de-op.

But chanserv has a command to change the topic without being opped, which the above MR uses. On that note, does the private SRE channel even have chanserv? I know _security doesn't.

On that note, does the private SRE channel even have chanserv? I know _security doesn't.

If its registered in ChanServ it does, There is a secondary option to have the "user/service" sit in the channel (cs set guard), but you can still use all features if its not.

I can't actually add reviewers in GitLab so pinging @Joe for review :)

Change 917915 had a related patch set uploaded (by RLazarus; author: RLazarus):

[operations/puppet@production] alerting_host: Disable vopsbot in #wikimedia-sre

https://gerrit.wikimedia.org/r/917915

oblivian merged https://gitlab.wikimedia.org/repos/sre/vopsbot/-/merge_requests/10

Use ChanServ to the change the topic to avoid needing to be opped

Mentioned in SAL (#wikimedia-operations) [2023-05-10T11:18:29Z] <_joe_> installing vopsbot 0.3.4 on alert1001 T329791

Change 918473 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[wikimedia/irc/ircservserv-config@master] Move sirenbot to full op

https://gerrit.wikimedia.org/r/918473

Change 918473 merged by jenkins-bot:

[wikimedia/irc/ircservserv-config@master] Move sirenbot to full op

https://gerrit.wikimedia.org/r/918473

Joe claimed this task.

This is solved thanks to @Legoktm's patch.

Mentioned in SAL (#wikimedia-operations) [2023-05-10T14:58:41Z] <cwhite> install vopsbot 0.3.4 on alert2001 T329791

Change 917915 abandoned by RLazarus:

[operations/puppet@production] alerting_host: Disable vopsbot in #wikimedia-sre

Reason:

Works now!

https://gerrit.wikimedia.org/r/917915