Identically named articles lost during reading list export in the Android app
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	Feb 16 2023, 12:53 AM

Description

Steps to reproduce

Add two articles to a reading list (e.g. the default Saved list) that have the same title (but are in different languages). E.g. https://hu.wikipedia.org/wiki/George_Armstrong_Custer and https://en.wikipedia.org/wiki/George_Armstrong_Custer.
Export the reading list to JSON.
Delete the articles from the reading list.
Import the list from JSON.

Actual result

Notice that one of the articles disappeared. (Looking at the export file, it disappeared during the export, not the import.)

Expected result

Notice that both articles were successfully roundtripped.

Software version

Android app 2.7.50429-alpha-2023-02-14, logged out

Event Timeline

Tacsipacsi created this task.Feb 16 2023, 12:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2023, 12:53 AM

Excellent catch; this will need to be addressed before we roll this out to production.

Sharvaniharan claimed this task.Feb 16 2023, 6:12 PM

Sharvaniharan moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.

Sharvaniharan moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Feb 16 2023, 7:30 PM

Dbrant moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Feb 16 2023, 8:17 PM

Appears to be fixed on 2.7.50430-r-2023-02-16

Thanks, works for me as well. In what commit/PR did you fix it? There’s no automatic comment from @gerritbot, as you’re not on Gerrit, but it’s still useful to connect tasks with code changes.

Sure, here are the relevant pull requests:
https://github.com/wikimedia/apps-android-wikipedia/pull/3836
https://github.com/wikimedia/apps-android-wikipedia/pull/3837

And it may be worth looking into a GitHub action that automatically posts on a Phab task upon a successful merge, as gerritbot does.

In T329805#8625159, @Dbrant wrote:

Sure, here are the relevant pull requests:
https://github.com/wikimedia/apps-android-wikipedia/pull/3836
https://github.com/wikimedia/apps-android-wikipedia/pull/3837

Thanks!

And it may be worth looking into a GitHub action that automatically posts on a Phab task upon a successful merge, as gerritbot does.

Or into moving to GitLab? GitLab certainly has, or is going to have, notifications, as everything will move there. GitLab is much more similar to GitHub than Gerrit, so it may be sufficient for you.

JTannerWMF moved this task from Ready for PM signoff to Ready for release on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Feb 22 2023, 5:50 PM

Dbrant closed this task as Resolved.Feb 23 2023, 4:07 PM

Identically named articles lost during reading list export in the Android appClosed, ResolvedPublicBUG REPORTActions