Remove span from untranslated messages since they are not necessary and double quotes in their attributes break the JSON.
Description
Details
Title | Reference | Author | Source Branch | Dest Branch | |
---|---|---|---|---|---|
Remove HTML from untranslated messages | repos/commtech/autosuggest-sitelink!25 | samwilson | message-html-remove | main |
Related Objects
Event Timeline
samwilson opened https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/25
Remove HTML from untranslated messages
hmonroy merged https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/25
Remove HTML from untranslated messages
@Samwilson @HMonroy I tested the following languages (Korean, Italian, and Spanish). One thing that I noticed when I created the Korean article and Korean Wikidata right away, you see that Korea matched. If I started an Italian article and an Italian Wikidata, the description of the Wikidata shows the language I made, which in this example is Italian. When I get an existing American Wikidata and configure the Italian language into it, like Wikidata Q25, Autosuggest shows the American description. It does not show the Italian Wikidata, even though the test site language is Italian as seen in the screenshots. The same thing happened with Spanish but once I checked it again later, the descriptions went to Spanish. Not sure of the exact time it switched but it was more than 10 minutes. It definitely doesn't do it right away though. Is there a time on how long it would take effect? Also, the No descriptions were in their respective language except for Italian. It comes out in English, which is as designed according to the gadget translation page.
Translations: https://meta.wikimedia.org/wiki/MediaWiki:Gadget-AutosuggestSitelink-messages
Korean
Test link: https://test.wikipedia.org/wiki/%EB%8C%80%ED%95%9C%EB%AF%BC%EA%B5%AD_%EC%B6%95%EA%B5%AC_%EA%B5%AD%EA%B0%80%EB%8C%80%ED%91%9C%ED%8C%80
Test Wikidata link: https://test.wikidata.org/wiki/Q229354
Italian
Test link: https://test.wikipedia.org/wiki/Birra
Test Wikidata link:
https://test.wikidata.org/wiki/Q229355
https://test.wikidata.org/wiki/Q25
Spanish
Test link: https://test.wikipedia.org/wiki/Mandrill
Test Wikidata link:
https://test.wikidata.org/wiki/Q227307
https://test.wikidata.org/wiki/Q229232
Language | Translations | Wikidata | Test Wiki | |
Spanish | ||||
Korea | ||||
Italiano | ||||
@Samwilson @HMonroy This would probably be a separate ticket if you wanted me to create one for it. When I go to Add language and switch to another language, in this example Italian, it cuts off the beginning of a category from the right side of the menu as seen in the screenshot.
OS: macOS 13.0
Browser: Chrome 109
Environment: Beta
Test Link: https://test.wikipedia.org/wiki/Birra
@HMonroy and @Samwilson I created T330221: Test.Wiki: Part of category (Add interlanguage links) on the right side is getting cut off when you switch to a different language. for the above issue. Otherwise, I did not come across anything else during my testing. I will move this to Product sign-off, thanks!