Page MenuHomePhabricator

Refactor the current dLocal StatusNormalizers.
Closed, ResolvedPublic

Description

These all should share the same normalizeStatus implementation. Let's extract that out to a base class and make these three children of that class. The only difference is what constitutes success, and that can be declared on a per-child basis.

Event Timeline

Hi there @SuvamManna

Sure, you can work on it if you feel you could do that independently without much mentoring. It's a busy period for us at the moment, so we can't offer much mentoring support, but I can point you in the direction of some documentation that will help you get set up with a Wikimedia Developer account, access to Gerrit and a link to the Gerrit repository for this project, that you would need to submit the work. Does that sound ok?

Hi @SuvamManna, are you able to work on this task or do you need support?

Hi @SuvamManna, I'd have to complete this task as it's an impediment for some other tasks and the team has a deadline for the feature this task supports.

You could still contribute to this task by Code Review. However, if you'd want to work on some other tasks, feel free to look through our backlog or reach out and I'd be happy to assist.

Change 894706 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[wikimedia/fundraising/SmashPig@master] Refactor the current dLocal StatusNormalizers.

https://gerrit.wikimedia.org/r/894706

Change 894706 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Refactor the current dLocal StatusNormalizers.

https://gerrit.wikimedia.org/r/894706

XenoRyet set Final Story Points to 2.