Page MenuHomePhabricator
Create Task
Maniphest T329893

User menu in Vector 2022 shows links on hover (logged-in users)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • using Vector 2022 skin logged-in, open the User menu and hover with the mouse on the "Contributions" link.

What happens?:

  • a pop up is showing other links (not clickable)

What should have happened instead?:

  • links should be on the menu, not in a pop-up

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
It's really hard to log out with the pop up overlapping.

Tested with Windows 10, Chrome and Firefox

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fixes User menu in Vector 2022 shows links on hover (logged-in users)mediawiki/extensions/ContentTranslationmaster+1 -9
Fix contribution menu entrypoint in vector-2022 skinmediawiki/extensions/ContentTranslationwmf/1.40.0-wmf.24+1 -1
Fix contribution menu entrypoint in vector-2022 skinmediawiki/extensions/ContentTranslationwmf/1.40.0-wmf.23+1 -1
Fix contribution menu entrypoint in vector-2022 skinmediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Una_tantum created this task.Feb 16 2023, 8:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2023, 8:10 PM
Jdlrobson edited projects, added Language-Team, ContentTranslation; removed Vector 2022.Feb 16 2023, 10:18 PM
Jdlrobson subscribed.

I'm pretty sure we have another task for this somewhere.

gerritbot added a comment.Feb 17 2023, 5:37 PM

Change 890009 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Do not show contribution menu entrypoint in vector-2022 skin

https://gerrit.wikimedia.org/r/890009

gerritbot added a project: Patch-For-Review.Feb 17 2023, 5:37 PM
santhosh claimed this task.Feb 17 2023, 5:38 PM
santhosh triaged this task as Medium priority.
santhosh edited projects, added Language-Team (Language-2023-January-March), Unplanned-Sprint-Work; removed Language-Team.
santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-January-March) board.
Una_tantum updated the task description. (Show Details)Feb 17 2023, 6:49 PM
Una_tantum updated the task description. (Show Details)
Jdlrobson merged a task: T330034: Some items in the user menu are added to a non-selectable sub-menu in Vector-2022.Feb 20 2023, 1:35 AM
Jdlrobson added a subscriber: Theklan.
Aklapper added a comment.Feb 21 2023, 12:16 AM

This also happens in old (non-2022) Vector per T330111: Hovering over Contributions in top bar shows a popup on yuewiki

Aklapper merged a task: T330111: Hovering over Contributions in top bar shows a popup on yuewiki.Feb 21 2023, 12:16 AM
Aklapper added a subscriber: Al12si.
IZapico-WMF subscribed.Feb 21 2023, 1:16 AM

It was also reported to happen on tewiki at the DI talk page.

Aklapper merged a task: T330225: Unexpected additional menu when hovering on Contributions.Feb 21 2023, 8:23 PM
Aklapper added a subscriber: Samwalton9-WMF.
Al12si added a comment.Feb 22 2023, 9:15 AM

This is happening also with the Monobook and Timeless skins. It looks like the only skin that isn’t affected is MinervaNeue (mobile).

gerritbot added a comment.Feb 22 2023, 10:17 AM

Change 890009 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix contribution menu entrypoint in vector-2022 skin

https://gerrit.wikimedia.org/r/890009

Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2023-January-March) board.Feb 22 2023, 10:25 AM
Nikerabbit removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 22 2023, 11:00 AM
gerritbot added a comment.Feb 22 2023, 11:26 AM

Change 890863 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.24] Fix contribution menu entrypoint in vector-2022 skin

https://gerrit.wikimedia.org/r/890863

gerritbot added a project: Patch-For-Review.Feb 22 2023, 11:26 AM
gerritbot added a comment.Feb 22 2023, 11:28 AM

Change 890864 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.23] Fix contribution menu entrypoint in vector-2022 skin

https://gerrit.wikimedia.org/r/890864

gerritbot added a comment.Feb 23 2023, 8:16 AM

Change 890864 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.23] Fix contribution menu entrypoint in vector-2022 skin

https://gerrit.wikimedia.org/r/890864

Stashbot added a comment.Feb 23 2023, 8:17 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-23T08:17:19Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:890864|Fix contribution menu entrypoint in vector-2022 skin (T329893)]]

Stashbot added a comment.Feb 23 2023, 8:19 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-23T08:19:08Z] <kartik@deploy1002> kartik: Backport for [[gerrit:890864|Fix contribution menu entrypoint in vector-2022 skin (T329893)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

gerritbot added a comment.Feb 23 2023, 8:25 AM

Change 890863 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.24] Fix contribution menu entrypoint in vector-2022 skin

https://gerrit.wikimedia.org/r/890863

Stashbot added a comment.Feb 23 2023, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-23T08:30:27Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:890864|Fix contribution menu entrypoint in vector-2022 skin (T329893)]] (duration: 13m 08s)

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2023, 8:30 AM
Stashbot added a comment.Feb 23 2023, 8:31 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-23T08:31:49Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:890863|Fix contribution menu entrypoint in vector-2022 skin (T329893)]]

Stashbot added a comment.Feb 23 2023, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-23T08:33:43Z] <kartik@deploy1002> kartik: Backport for [[gerrit:890863|Fix contribution menu entrypoint in vector-2022 skin (T329893)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Feb 23 2023, 8:42 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-23T08:42:17Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:890863|Fix contribution menu entrypoint in vector-2022 skin (T329893)]] (duration: 10m 27s)

KartikMistry moved this task from Check after deployment to Done on the Language-Team (Language-2023-January-March) board.Feb 23 2023, 8:49 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.24; 2023-02-20); removed MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 23 2023, 1:00 PM
Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.Mar 13 2023, 11:57 AM
Pginer-WMF closed this task as Resolved.Mar 28 2023, 11:17 AM
Patafisik_WMF added subscribers: Pginer-WMF, Patafisik_WMF.Jul 15 2023, 3:51 PM

@Pginer-WMF this is happening again, can you re-open this task, please? See this report and my comment here T339870#9000403 for more information.

Samwalton9-WMF reopened this task as Open.Jul 15 2023, 7:28 PM

I'd been looking for this ticket to re-open it - confirming that I'm seeing this too.

Pginer-WMF edited projects, added Language-Team (Language-2023-July-September); removed Language-Team (Language-2023-January-March).Jul 17 2023, 7:50 AM
Pginer-WMF moved this task from Quarter Backlog to Priority: Translation on the Language-Team (Language-2023-July-September) board.
Pginer-WMF mentioned this in T301321: The translation tool is not present in the sticky header of Vector 2022.Jul 17 2023, 8:02 AM

A Regression seems to be affecting this and the related ticket: T301321: The translation tool is not present in the sticky header of Vector 2022

gerritbot added a comment.Jul 17 2023, 9:09 PM

Change 938932 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] Fixes User menu in Vector 2022 shows links on hover (logged-in users)

https://gerrit.wikimedia.org/r/938932

gerritbot added a project: Patch-For-Review.Jul 17 2023, 9:09 PM
gerritbot added a comment.Jul 18 2023, 10:46 AM

Change 938932 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fixes User menu in Vector 2022 shows links on hover (logged-in users)

https://gerrit.wikimedia.org/r/938932

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 18 2023, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 11:11 AM
Jdlrobson merged a task: T342337: Vector 2022 desktop Log out menu item covered.Jul 20 2023, 5:52 PM
Jdlrobson added a subscriber: Bean49.
Pginer-WMF edited projects, added Language-Team (Language-2023-October-December); removed Language-Team (Language-2023-July-September).Oct 2 2023, 9:02 AM
Pginer-WMF moved this task from Quarter Backlog to Priority: Translation on the Language-Team (Language-2023-October-December) board.
santhosh moved this task from Priority: Translation to Needs QA on the Language-Team (Language-2023-October-December) board.Oct 11 2023, 4:55 AM
EChukwukere-WMF subscribed.Oct 25 2023, 2:22 AM

Test status: QA PASS

the contributions no longer show the overlapping pop up

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2023-October-December) board.Oct 25 2023, 2:22 AM
Pginer-WMF closed this task as Resolved.Oct 27 2023, 8:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits