Page MenuHomePhabricator

Epic: Review mock ups to determine complexity
Closed, ResolvedPublic

Description

Event Timeline

I manipulated the DOM for https://test.wikipedia.org/w/index.php?title=Yann_Dedet&diff=prev&oldid=557919 to make it look according to the new design.
Current:

Screenshot from 2023-02-17 10-46-00.png (676×1 px, 129 KB)

New Design:

Screenshot from 2023-02-17 14-55-52.png (676×1 px, 170 KB)

In the new design screenshot, I added a rowspan=5 to the td on the left that displays the content "Dedet has been workin..." and also moved the CSS classes to the div. Ex <div class="diff-deletedline diff-side-deleted">

We can accomplish the new design by moving the CSS styles to the div elements (ex <td><div class="diff-deletedline diff-side-deleted">>Lorem ipsum ...</div></td>) from the td elements (<td class="diff-deletedline diff-side-deleted"><div>Lorem ipsum ...</div></td>).

We would also need to to introduced a new variable to the method TableFormatter::printWordDiff to determine the value of a rowspan attribute for the td that is going to expand across different rows so that it allows the opposite side to print cell without having to worry about aligning to the other side. We would need to look ahead to see how many cells below the cell being printed are empty.