Page MenuHomePhabricator

[unplanned] Officially drop ES5 support for page previews
Closed, ResolvedPublicBUG REPORT

Description

I noticed that page previews is currently not working for ES5 users as ext.maths.popups is an ES6 module which causes the mw.loader call inside ext.popups/index.js to reject meaning the feature never gets activated. This was broken in Iefe98c1f0422dbf034e385b1a41a859d030a2cf4.

The problematic code is:

mw.loader.using( ['ext.math.popups', 'ext.popups.main' ] ) ).then( success, reject )

Because ext.math.popups is an es6 module it will be an unknown module on ES5 browsers leading to the reject handler to call and ext.popups.main to not be loaded.

I talked to @ovasileva about whether we should restore ES5 support for page previews, and given the recent trend away from IE11 (T178356) and inside Vector 2022 (most features are ES6 now), we decided it made sense to drop page previews support for ES5 users.

Event Timeline

Change 889872 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Remove targets definitions and limit page previews to ES6 browsers

https://gerrit.wikimedia.org/r/889872

Reedy updated the task description. (Show Details)

Change 889872 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove targets definitions and limit page previews to ES6 browsers

https://gerrit.wikimedia.org/r/889872

Jdlrobson renamed this task from Officially drop ES5 support for page previews to [unplanned] Officially drop ES5 support for page previews.Feb 22 2023, 4:54 PM
Jdlrobson triaged this task as Medium priority.

@ovasileva patch got merged so adding this to sign off to make sure you are aware.

Looks good, resolving