Deploy phabricator to aphlict2001.codfw.wmnet
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• eoghan
	Feb 16 2023, 11:57 PM

Description

tl;dr: Can we add aphlict1001.eqiad.wmnet and aphlict2001.codfw.wmnet to the phabricator scap targets and deploy?

We added a new aphlict host in codfw in T322369, however puppet is currently throwing an error:

Feb 16 22:42:51 aphlict2001 puppet-agent[313667]: (/Stage[main]/Profile::Phabricator::Aphlict/Scap::Target[phabricator/deployment]/Package[phabricator/deployment]/ensure) change from 'absent' to 'present' failed: Execution of '/usr/bin/scap deploy-local --repo phabricator/deployment -D log_json:False' returned 70: #007

This line in the puppet config depends on phabricator/deployment being deployed with scap on the machine, and we can see in aphlict1001.eqiad that directory is there. I think this error, however, is because the host isn't included in the scap targets.

This hasn't been a problem on the existing host because it looks like the host was manually deployed to somehow (the dates on /srv/deployment/phabricator/deployment are from June 2020).

So I think to get us to the correct state, we need to add both hosts to be deploy targets of phabricator in scap, and initiate a deployment.

Details

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	scap: add aphlict2001 to phabricator-targets	repos/phabricator/deployment!3	brennen	work/aphlict2001-target	wmf/stable

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• eoghan	T329908 Deploy phabricator to aphlict2001.codfw.wmnet
		Resolved		• eoghan	T330393 puppet/scap: failing on aphlict2001

Event Timeline

• eoghan created this task.Feb 16 2023, 11:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2023, 11:57 PM

Dzahn added a project: collaboration-services.Feb 17 2023, 12:16 AM

Dzahn added a project: Phabricator.

brennen subscribed.Feb 17 2023, 12:22 AM

LSobanski moved this task from Incoming to Consultation on the collaboration-services board.Feb 20 2023, 4:23 PM

brennen mentioned this in T330393: puppet/scap: failing on aphlict2001.Feb 23 2023, 7:07 PM

Dzahn added a subtask: T330393: puppet/scap: failing on aphlict2001.Feb 23 2023, 7:09 PM

brennen opened https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/3

scap: add aphlict2001 to phabricator-targets

gerritbot added a project: Patch-For-Review.Feb 23 2023, 7:10 PM

This should also fix T330393.

brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/3

scap: add aphlict2001 to phabricator-targets

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2023, 7:30 PM

19:41 < mutante> scap has defaults to use gerrit as origin: modules/scap/lib/puppet/provider/scap_source/default.rb: "https://gerrit.wikimedia.org/r/#{repo_name}.git"
19:42 < mutante> so you cant use gitlab repos as origin for something deployed with scap
19:42 < mutante> this currently is a problem for phabricator repos which got moved from phabricator itself to gitlab

brennen renamed this task from Deploy phabricator to aphlict2002.codfw.wmnet to Deploy phabricator to aphlict2001.codfw.wmnet.Feb 23 2023, 9:22 PM

also see T331278

Change 891841 had a related patch set uploaded (by Brennen Bearnes; author: EoghanGaffney):

[operations/puppet@production] Split out a new class for phabricator::config

https://gerrit.wikimedia.org/r/891841

gerritbot added a project: Patch-For-Review.Mar 6 2023, 9:59 PM