This work has been split out from the Kartographer upgrades, because it will require some additional testing and a separate deployment.
The new mapdata library changes the internal result format for expanded ExternalData. Write tests to prove correctness and update the dependency.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Upgrade to mapdata 0.9; test | mediawiki/services/kartotherian | master | +33 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | None | T327151 Defective Kartographer maps in Wikivoyage: empty maps and wrong group names | ||
| Resolved | None | T331977 Deploy recent map server work to production ( May 2023 ) | |||
| Resolved | thiemowmde | T328760 Mapdata library should not change structure of GeoJSON | |||
| Resolved | thiemowmde | T329924 Update kartotherian to use mapdata 0.9.0 (external data is expanded in-place) |
After thinking about this, I see that there's no difference from the perspective of kartotherian. Mapdata failures are still returned at the top level and so are filtered out by testing each for a .failed property. Successful external data expansion is encapsulated inside of the GeoJSON which is opaque here.
I'll write a test to demonstrate that failed groups are skipped.
Change 889991 had a related patch set uploaded (by Awight; author: Awight):
[mediawiki/services/kartotherian@master] Upgrade to mapdata 0.9; test
Change 889991 merged by jenkins-bot:
[mediawiki/services/kartotherian@master] Upgrade to mapdata 0.9; test