- Modify the use case to use exceptions instead of response objects.
- Modify validators by:
- Move the validation logic into the validator, in a new method assertValidRequest.
- Throw a UseCaseException inside the new method.
- Modify related route handler.
- Since there is now only one response for use cases (the SuccessResponse), we will rename it to just Response.
- Modify related tests.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Muhammad_Yasser_Jazirahly_WMDE | T327527 Should our use cases throw exceptions instead of returning different response objects? | |||
| Resolved | WMDE-leszek | T329947 🚨 Use exceptions instead of response objects in previous use cases | |||
| Resolved | • Muhammad_Yasser_Jazirahly_WMDE | T329956 🚨 Modify GetItemStatement |
Event Timeline
Comment Actions
Change 890342 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):
[mediawiki/extensions/Wikibase@master] REST: Modify GetItemStatement to use exceptions
Comment Actions
Change 890830 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):
[mediawiki/extensions/Wikibase@use-exceptions-in-replace-item-statement] REST: Modify GetItemStatement to use exceptions
Comment Actions
Change 890830 abandoned by Muhammad Jaziraly:
[mediawiki/extensions/Wikibase@use-exceptions-in-replace-item-statement] REST: Modify GetItemStatement to use exceptions
Reason:
Modification for an already-created patch.
Comment Actions
Change 890342 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Modify GetItemStatement to use exceptions
Comment Actions
Change 891553 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):
[mediawiki/extensions/Wikibase@master] REST: Rename newStatementNotFoundError() method
Comment Actions
Change 891553 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Rename newStatementNotFoundError() method