Wouldn't code reviewers be added in the code review tool though, rather than the ticket system, to notify them of incoming review requests?

For more context, I am in a team which is not 100% developers. The information (on the workboard) that a code is being reviewed is of particular importance to project managers, designers and program managers who don't use Gerrit (and shouldn't be expected to). A similar tool that's popular with product managers - Trello - allows and visualizes multiple assignees.

FWIW, this is probably either not a big deal to add or kind of a pain. I can investigate which. Maybe it could be a patch to Phorge.

(I think we already add an extra thing or two to the workboard items, and if so it might be as simple as repeating that. Then again, it might not be.)

If it's easy... great! A fix would be much appreciated.
If it's complicated... I'd be sad, but I would understand if you want to decline this.

dylsss updated https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/1

Draft: Add support for showing other assignee on project board.

Screenshot from above patch:

dylsss updated https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/1

Thanks for this! I'll give it a look over shortly.

Hey @brennen, do you have any idea of when https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/1 might be available in a deployed version of Phabricator ? This came up today in our sprint review meeting as we realized a large task that should have 2 assignees only had 1 and having this visual cue would have identified that much sooner.

I still need to confirm that it works, but I'm looking to get a Phabricator deploy window scheduled some time this week, so hopefully not long.

brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/1

Add support for showing other assignee on project board.

While this looked fine for us on the dashboard linked above, we are getting reports of issues in another workboard at T332234. May have to be reverted.

Are we trying this patch again? Anything I can do to help move this one along?

Yes, once I'm confident in a fix for T332234: Cannot access workboard: Unhandled Exception: Undefined variable: other_assignees. I'll probably schedule a brief update window yet this week.

brennen opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/2

workboards: Initialize $other_assignees array

brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/2

workboards: Initialize $other_assignees array

Mentioned in SAL (#wikimedia-operations) [2023-03-30T15:44:01Z] <mutante> phabricator maintenance window / deployment ended (T329974)

Amazing.

Cross-referencing to T396878: "Other assignee" icon disappears briefly after loading a workboard in case anyone subscribed here knows what might be going on there :)