Maniphest T330050

🚨 Modify RemoveItemStatement
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Feb 20 2023, 8:03 AM

Project Tags

Referenced Files

None

Subscribers

• Muhammad_Yasser_Jazirahly_WMDE

Ollie.Shotton_WMDE

Description

Modify use case to use exceptions instead of response objects.
Modify validators by:
- Move the validation logic into the validator, in a new method assertValidRequest.
- Throw a UseCaseException inside the new method.
Since there is now only one response for use cases (the SuccessResponse), we will rename it to just Response.
Modify related tests.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	REST: Modify RemoveItemStatement to use exceptions	Silvan Heintze	mediawiki/extensions/Wikibase	master	+193 -284

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Muhammad_Yasser_Jazirahly_WMDE	T327527 Should our use cases throw exceptions instead of returning different response objects?
		Resolved		WMDE-leszek	T329947 🚨 Use exceptions instead of response objects in previous use cases
		Resolved		Silvan_WMDE	T330050 🚨 Modify RemoveItemStatement

Event Timeline

Silvan_WMDE created this task.Feb 20 2023, 8:03 AM

• Muhammad_Yasser_Jazirahly_WMDE mentioned this in T329947: 🚨 Use exceptions instead of response objects in previous use cases.Feb 20 2023, 9:13 AM

• I merged a task: T330051: 🚨 Modify ReplaceItemStatement.Feb 20 2023, 11:45 AM

Silvan_WMDE claimed this task.Feb 22 2023, 11:49 AM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 23) board.

Change 891550 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Modify RemoveItemStatement to use exceptions

https://gerrit.wikimedia.org/r/891550

gerritbot added a project: Patch-For-Review.Feb 23 2023, 2:11 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 28 2023, 10:02 AM

WMDE-leszek edited projects, added: Wikibase Product Platform (v1) (Sprint 24); removed: Wikibase Product Platform (v1) (Sprint 23).Feb 28 2023, 10:25 AM

WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 24) board.

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 24) board.Feb 28 2023, 11:48 AM

Change 891550 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Modify RemoveItemStatement to use exceptions

https://gerrit.wikimedia.org/r/891550

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Feb 28 2023, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2023, 12:10 PM

WMDE-leszek closed this task as Resolved.Mar 28 2023, 8:45 PM