Maniphest T330051

🚨 Modify ReplaceItemStatement
Closed, ResolvedPublic
Actions

Assigned To

• Muhammad_Yasser_Jazirahly_WMDE

Authored By

	Silvan_WMDE
	Feb 20 2023, 8:04 AM

Tags

Referenced Files

None

Subscribers

• Muhammad_Yasser_Jazirahly_WMDE

Ollie.Shotton_WMDE

Description

Modify use case to use exceptions instead of response objects.
Modify validators by:
- Move the validation logic into the validator, in a new method assertValidRequest.
- Throw a UseCaseException inside the new method.
Since there is now only one response for use cases (the SuccessResponse), we will rename it to just Response.
Modify related tests.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST: Modify ReplaceItemStatement to use exceptions	mediawiki/extensions/Wikibase	master	+423 -412

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Muhammad_Yasser_Jazirahly_WMDE	T327527 Should our use cases throw exceptions instead of returning different response objects?
		Resolved		WMDE-leszek	T329947 🚨 Use exceptions instead of response objects in previous use cases
		Resolved		• Muhammad_Yasser_Jazirahly_WMDE	T330051 🚨 Modify ReplaceItemStatement

Event Timeline

Silvan_WMDE created this task.Feb 20 2023, 8:04 AM

• Muhammad_Yasser_Jazirahly_WMDE mentioned this in T329947: 🚨 Use exceptions instead of response objects in previous use cases.Feb 20 2023, 9:13 AM

• I closed this task as a duplicate of T330050: 🚨 Modify RemoveItemStatement.Feb 20 2023, 11:45 AM

• I subscribed.

This comment was removed by • I.

Oops, sorry, I didn't read the title properly, they were too close.

• I unsubscribed.Feb 20 2023, 11:49 AM

• Muhammad_Yasser_Jazirahly_WMDE claimed this task.Feb 21 2023, 9:26 AM

• Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 23) board.

Change 890839 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Modify ReplaceItemStatement to use exceptions

https://gerrit.wikimedia.org/r/890839

gerritbot added a project: Patch-For-Review.Feb 21 2023, 3:17 PM

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 22 2023, 3:07 PM

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 23 2023, 9:02 AM

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 24 2023, 8:30 AM

Change 890839 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Modify ReplaceItemStatement to use exceptions

https://gerrit.wikimedia.org/r/890839

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 27 2023, 9:08 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2023, 9:10 AM

WMDE-leszek closed this task as Resolved.Mar 21 2023, 9:33 AM