Page MenuHomePhabricator

Text selection doesn't work in Firefox when doing translation
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Open some article for translation. E.g. https://en.wikipedia.org/wiki/Special:ContentTranslation?title=Special:ContentTranslation&from=pl&to=en&page=Jan+Pike&targettitle=Jan+Pike&safemode=1
  2. Start translation (in this case you will have ignore warnings that the article already exists).
  3. Translate some paragraph.
  4. Try to select text (or even to place the cursor) with a mouse.

Note that this happens both ways (from en to pl, from pl to en). It seems that target/source language doesn't matter.

What happens?:

Screen flashes, some state changes, something happens with a sidebar. See video below. This happens all the time, even in safemode, so should be easily repeatable. The problem was confirmed by me after a report of another user of plwiki (Archiwald).

Note! There is a problem with the keyboard too. In VE I can use SHIFT+END to select the end of line, I can use SHIFT+DOWN ARROW.

What should have happened instead?:

Should be able to use a mouse and keyboard for selection.

Software version (skip for WMF-hosted wikis like Wikipedia):

I think this might have been broken this year, maybe even in last deployment. I used CT on 21 Jan 2023, 23:38 CET and the problem wasn't there (I'm quite sure I would notice).

Other information (browser name/version, screenshots, etc.):

Firefox 110, Windows 10.

Video - first trying to click (place a cursor), then to select text (part or paragraph).
https://commons.wikimedia.org/wiki/File:Content_Translation_text_selection_bug_2023-02-20,_Firefox.webm

Event Timeline

Change 890455 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890455

Change 890455 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890455

Change 890503 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (08c5c702b)

https://gerrit.wikimedia.org/r/890503

Change 890503 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (08c5c702b)

https://gerrit.wikimedia.org/r/890503

Change 890456 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@wmf/1.40.0-wmf.23] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890456

Change 890504 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.23] Update VE core submodule to f2528875026a

https://gerrit.wikimedia.org/r/890504

Change 890456 merged by jenkins-bot:

[VisualEditor/VisualEditor@wmf/1.40.0-wmf.23] Revert "Try to prevent selections inside ref/template nodes on Firefox"

https://gerrit.wikimedia.org/r/890456

Change 890504 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.23] Update VE core submodule to f2528875026a

https://gerrit.wikimedia.org/r/890504

Mentioned in SAL (#wikimedia-operations) [2023-02-20T21:23:59Z] <zabe@deploy1002> zabe: T329983 T330104 synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-20T21:33:40Z] <zabe@deploy1002> Finished scap: T329983 T330104 (duration: 11m 51s)

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

Should be fixed on all Wikimedia wikis now.

Nux claimed this task.

Works, thanks.

✅Mouse selection.
✅Cursor placement with a mouse.
✅SHIFT+END to select the end of line.
✅SHIFT+DOWN ARROW to select to next line.
🟡CTRL+A selects current paragraph. Which is fine I guess in CT.

Keyboard navigation/selection through paragraphs doesn't work (not able to go to next/previous paragraph), but I think that didn't work before.