start-rt-test.sh doesn't report exit codes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Feb 20 2023, 9:39 PM

Description

start-rt-test.sh failed to checkout the right commit with,

fatal: detected dubious ownership in repository at '/srv/parsoid-testing'
To add an exception for this directory, call:
	git config --global --add safe.directory /srv/parsoid-testing

Resulting in,
https://www.mediawiki.org/w/index.php?title=Parsoid%2FRound-trip_testing&diff=5784446&oldid=5049938

but it didn't really prevent rt testing from starting with the wrong commit (though reporting it was testing the right hash in the web ui). Since we rely pretty heavily on the result of rt testing being clean, this failure mode seems problematic and too heavily reliant on developer noticing that something went wrong.

The script should at least check the exit codes for the git checkout and either report in red or fail hard.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Bump parsoid to 0.17.0-a18	mediawiki/vendor	master	+648 -273
	Make start-rt-test.sh fail early	mediawiki/services/parsoid	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned Here: T325128: git: detected dubious ownership in repository at '/srv/mediawiki-staging'

Event Timeline

Arlolra created this task.Feb 20 2023, 9:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2023, 9:39 PM

The git issue comes from a recent security update with details at T325128#8465719. Setting git config safe.directory is indeed the workaround ;)

To have start-rt-test.sh to abort immediately when any command fails, use set -e (and while at it error out when a variable is not set with -u and abort when a command in a chain of pipe fails with -o pipefail). I typically stick at the top of the shell script: