Maniphest T330139

🚨 Modify GetItemStatements
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ollie.Shotton_WMDE
	Feb 21 2023, 11:00 AM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

Modify the use case to use exceptions instead of response objects
Modify validators by:
- Move the validation logic into the validator, in a new method assertValidRequest
- Throw a UseCaseException inside the new method
Modify related route handler
Since there is now only one response for use cases (the SuccessResponse), we will rename it to just Response
Modify related tests

Details

	Subject	Repo	Branch	Lines +/-
	REST: Modify GetItemStatements to throw exceptions	mediawiki/extensions/Wikibase	master	+105 -114

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Muhammad_Yasser_Jazirahly_WMDE	T327527 Should our use cases throw exceptions instead of returning different response objects?
		Resolved		WMDE-leszek	T329947 🚨 Use exceptions instead of response objects in previous use cases
		Resolved		Silvan_WMDE	T330139 🚨 Modify GetItemStatements

Event Timeline

Ollie.Shotton_WMDE created this task.Feb 21 2023, 11:00 AM

Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 21 2023, 11:07 AM

Muhammad_Yasser_Jazirahly_WMDE mentioned this in T329947: 🚨 Use exceptions instead of response objects in previous use cases.Feb 22 2023, 11:53 AM

Change 891264 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Modify GetItemStatements to throw exceptions

https://gerrit.wikimedia.org/r/891264

gerritbot added a project: Patch-For-Review.Feb 22 2023, 12:19 PM

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 23 2023, 2:07 PM

Silvan_WMDE claimed this task.Feb 27 2023, 11:50 AM

Silvan_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 23) board.

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 27 2023, 12:40 PM

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 24); removed Wikibase Product Platform (v1) (Sprint 23).Feb 28 2023, 10:26 AM

WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 24) board.

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 24) board.Feb 28 2023, 11:48 AM

Change 891264 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Modify GetItemStatements to throw exceptions

https://gerrit.wikimedia.org/r/891264

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Feb 28 2023, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2023, 12:10 PM

WMDE-leszek closed this task as Resolved.Mar 28 2023, 8:45 PM