Maniphest T330167

🚨 Modify GetItem to throw use case exceptions
Closed, ResolvedPublic
Actions

Assigned To

• Muhammad_Yasser_Jazirahly_WMDE

Authored By

	Jakob_WMDE
	Feb 21 2023, 3:09 PM

Tags

Referenced Files

None

Subscribers

Description

Modify the use case to use exceptions instead of response objects.
Modify validators by:
- Move the validation logic into the validator, in a new method assertValidRequest.
- Throw a UseCaseException inside the new method.
Modify related route handler.
Since there is now only one response for use cases (the SuccessResponse), we will rename it to just Response.
Modify related tests.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST: Modify GetItem to use exceptions	mediawiki/extensions/Wikibase	master	+113 -177

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Muhammad_Yasser_Jazirahly_WMDE	T327527 Should our use cases throw exceptions instead of returning different response objects?
		Resolved		WMDE-leszek	T329947 🚨 Use exceptions instead of response objects in previous use cases
		Resolved		• Muhammad_Yasser_Jazirahly_WMDE	T330167 🚨 Modify GetItem to throw use case exceptions

Event Timeline

Jakob_WMDE created this task.Feb 21 2023, 3:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2023, 3:09 PM

Jakob_WMDE updated the task description. (Show Details)Feb 21 2023, 3:09 PM

• Muhammad_Yasser_Jazirahly_WMDE mentioned this in T329947: 🚨 Use exceptions instead of response objects in previous use cases.Feb 22 2023, 11:53 AM

• Muhammad_Yasser_Jazirahly_WMDE claimed this task.Feb 22 2023, 4:13 PM

• Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 23) board.

Change 891323 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Modify GetItem to use exceptions

https://gerrit.wikimedia.org/r/891323

gerritbot added a project: Patch-For-Review.Feb 22 2023, 4:18 PM

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 22 2023, 5:33 PM

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 23) board.Feb 27 2023, 1:50 PM

Change 891323 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Modify GetItem to use exceptions

https://gerrit.wikimedia.org/r/891323

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2023, 2:10 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 27 2023, 3:00 PM

WMDE-leszek closed this task as Resolved.Mar 21 2023, 9:33 AM