Page MenuHomePhabricator
Create Task
Maniphest T330213

1.41.0-wmf.7 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jeena
Release Version
1.41.0-wmf.7
Release Date
Mon, May 1, 12:00 AM

2023 week 18 1.41-wmf.7 Changes wmf/1.41.0-wmf.7

This MediaWiki Train Deployment is scheduled for the week of Monday, May 1st:

Monday May 1stTuesday, May 2ndWednesday, May 3rdThursday, May 4thFriday
Backports only.Branch wmf.7 and deploy to Group 0 Wikis.Deploy wmf.7 to Group 1 Wikis.Deploy wmf.7 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.7 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.6
Next: 1.41.0-wmf.8
ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+328 -328group1 wikis to 1.41.0-wmf.7
operations/mediawiki-configmaster+328 -328group2 wikis to 1.41.0-wmf.7
operations/mediawiki-configmaster+544 -544group1 wikis to 1.41.0-wmf.7
operations/mediawiki-configmaster+131 -131group0 wikis to 1.41.0-wmf.7
operations/mediawiki-configmaster+4 -4testwikis wikis to 1.41.0-wmf.7
mediawiki/corewmf/1.41.0-wmf.7+991 -3Branch commit for wmf/1.41.0-wmf.7
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Feb 21 2023, 5:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2023, 5:57 PM
thcipriani assigned this task to • brennen.Apr 28 2023, 2:40 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jeena.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
gerritbot added a comment.Tue, May 2, 2:07 AM

Change 913935 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.7] Branch commit for wmf/1.41.0-wmf.7

https://gerrit.wikimedia.org/r/913935

gerritbot added a project: Patch-For-Review.Tue, May 2, 2:07 AM
gerritbot added a comment.Tue, May 2, 2:26 AM

Change 913935 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.7] Branch commit for wmf/1.41.0-wmf.7

https://gerrit.wikimedia.org/r/913935

gerritbot added a comment.Tue, May 2, 3:01 AM

Change 914036 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/914036

gerritbot added a comment.Tue, May 2, 3:02 AM

Change 914036 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/914036

Stashbot added a comment.Tue, May 2, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T03:02:38Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.7 refs T330213

Stashbot added a comment.Tue, May 2, 3:52 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T03:51:59Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.7 refs T330213 (duration: 49m 21s)

hashar added a subscriber: hashar.Tue, May 2, 4:43 AM

I went to browse https://test.wikipedia.org/wiki/Main_Page it has a top banner showing the proper version:

This is a test of release of MediaWiki 1.41.0-wmf.7 (087c2fc). Please report issues you encounter.

While the main page states:

The current version of MediaWiki running on this wiki is 1.41.0-wmf.6 (ccab434).

In the wikitext that is the token {{CURRENTVERSION}}. I went to purge the page and that is gone :)

Ladsgroup added a subscriber: Ladsgroup.Tue, May 2, 1:17 PM
Ladsgroup added a comment.Tue, May 2, 1:50 PM
Risky Patch! 🚂🔥
Ladsgroup added a comment.Tue, May 2, 1:50 PM

Also if you see anything with externallinks in logs, that's probably me. Ping me

Stashbot added a comment.Tue, May 2, 6:01 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T18:01:53Z] <brennen> train 1.41.0-wmf.7 (T330213): no current blockers, rolling to group1 with scap train

Stashbot added a comment.Tue, May 2, 6:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T18:03:14Z] <brennen> train 1.41.0-wmf.7 (T330213): (correction: group0 today)

gerritbot added a comment.Tue, May 2, 6:03 PM

Change 914376 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/914376

gerritbot added a comment.Tue, May 2, 6:04 PM

Change 914376 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/914376

Stashbot added a comment.Tue, May 2, 6:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-02T18:11:45Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.7 refs T330213

Stashbot added a comment.Wed, May 3, 6:08 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-03T18:08:20Z] <brennen> train 1.41.0-wmf.7 (T330213): logs quiet and no current blockers, rolling to group1

gerritbot added a comment.Wed, May 3, 6:08 PM

Change 914879 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/914879

gerritbot added a comment.Wed, May 3, 6:09 PM

Change 914879 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/914879

Stashbot added a comment.Wed, May 3, 6:16 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-03T18:16:38Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.7 refs T330213

Stashbot added a comment.Wed, May 3, 6:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-03T18:22:57Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.7 refs T330213 (duration: 06m 18s)

Stashbot added a comment.Thu, May 4, 6:08 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-04T18:08:11Z] <brennen> train 1.41.0-wmf.7 (T330213): logs fairly quiet and no current blockers, rolling to group2

gerritbot added a comment.Thu, May 4, 6:08 PM

Change 915812 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/915812

gerritbot added a comment.Thu, May 4, 6:09 PM

Change 915812 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/915812

Stashbot added a comment.Thu, May 4, 6:16 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-04T18:16:35Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.7 refs T330213

• brennen mentioned this in T336008: MWException: Internal error in ApiQueryRevisionsBase::getRevisionRecords: RevisionStore does not return record for [n].Thu, May 4, 8:14 PM
• brennen added a comment.Thu, May 4, 8:17 PM

@Ladsgroup any chance T336008: MWException: Internal error in ApiQueryRevisionsBase::getRevisionRecords: RevisionStore does not return record for [n] is fallout of above-mentioned risky patch?

RhinosF1 added a subscriber: RhinosF1.Thu, May 4, 8:22 PM
gerritbot added a comment.Thu, May 4, 8:31 PM

Change 915841 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/915841

• brennen added a subtask: T336008: MWException: Internal error in ApiQueryRevisionsBase::getRevisionRecords: RevisionStore does not return record for [n].Thu, May 4, 8:31 PM
gerritbot added a comment.Thu, May 4, 8:32 PM

Change 915841 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.7

https://gerrit.wikimedia.org/r/915841

• brennen added a comment.Thu, May 4, 8:33 PM

T336008 has spiked quite a bit. Rolling train back to group1.

Ladsgroup added a comment.Thu, May 4, 8:34 PM
In T330213#8828156, @brennen wrote:

@Ladsgroup any chance T336008: MWException: Internal error in ApiQueryRevisionsBase::getRevisionRecords: RevisionStore does not return record for [n] is fallout of above-mentioned risky patch?

That doesn't look like it to be honest. It can be something else related to database but I can't say for sure without proper debugging

Ladsgroup added a comment.Thu, May 4, 8:38 PM

From a brief look, it's highly unlikely. It's something else.

• brennen added a comment.Thu, May 4, 8:41 PM

From a brief look, it's highly unlikely. It's something else.

Ack, thanks! Seemed worth checking.

Stashbot added a comment.Thu, May 4, 8:51 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-04T20:51:13Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.7 refs T330213

Stashbot added a comment.Thu, May 4, 8:57 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-04T20:57:16Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.7 refs T330213 (duration: 06m 02s)

• brennen added a comment.Thu, May 4, 10:00 PM

End of US workday update: Doing a diagnostic backport for T336008 and pausing the train for the day.

Stashbot added a comment.Fri, May 5, 6:25 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-05T18:25:20Z] <brennen> train 1.41.0-wmf.7 (T330213): trying revert for T336008, T336022

Stashbot mentioned this in T336022: 1.41.0-wmf.7 increases Memcached call rate by +100%.Fri, May 5, 6:25 PM
• brennen removed a subtask: T336008: MWException: Internal error in ApiQueryRevisionsBase::getRevisionRecords: RevisionStore does not return record for [n].Fri, May 5, 7:18 PM
• brennen mentioned this in T336083: Nuke: Error: Class 'Mediawiki\Page\File\FileDeleteForm' not found.Fri, May 5, 7:59 PM
Krinkle removed a subtask: T336022: 1.41.0-wmf.7 increases Memcached call rate by +100%.Fri, May 5, 10:24 PM
• brennen changed the task status from Open to In Progress.Fri, May 5, 10:42 PM

With blockers cleared, I'm going to say we'll go to all wikis first thing (MDT) Monday morning.

ssastry mentioned this in T336101: Stray __TOC__ added by the reply tool.Sun, May 7, 4:24 AM
Stashbot added a comment.Mon, May 8, 2:40 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-08T14:40:02Z] <brennen> train 1.41.0-wmf.7 (T330213): proceeding to all wikis

• brennen mentioned this in T330214: 1.41.0-wmf.8 deployment blockers.Mon, May 8, 2:52 PM
• brennen mentioned this in T336179: scap deploy-promote uses latest train blocker, which is wrong if a train has been blocked over the weekend.Mon, May 8, 3:31 PM
• brennen closed this task as Resolved.Mon, May 8, 3:48 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL