Page MenuHomePhabricator

Two Column: Update layout to remove unnecessary white space in cells
Closed, DeclinedPublic8 Estimated Story Points

Description

Restructure the HTML so that we can eliminate unnecessary white spaces at the bottom of cells.

Feature Summary

On the current experience, the HTML is a table that displays a row for every diff and in some cases there are white spaces in some cells, which show spaces that do not correctly represent the diff

In this example we see a chunk of white spaces after "Small roles" on the Right Hand Side:

Screenshot from 2023-02-17 10-46-00.png (676×1 px, 129 KB)

Use Cases

  • As a viewer of the Two-column Wikitext Diff diff on Desktop: I do not see white spaces under paragraphs that do not represent an edit.

Acceptance Criteria

  • Update the CSS in core to maintain new structure.
  • New CSS changes should not affect the UI in core.
  • Update HTML layout it so that we can accommodate new designs.

Engineering - Proposed Layout

New Design:

Screenshot from 2023-02-17 14-55-52.png (676×1 px, 170 KB)

In the new design screenshot, I added a rowspan=5 to the td on the left that displays the content "Dedet has been workin..." and also moved the CSS classes to the div. Ex <div class="diff-deletedline diff-side-deleted">

We can accomplish the new design by moving the CSS styles to the div elements (ex <td><div class="diff-deletedline diff-side-deleted">>Lorem ipsum ...</div></td>) from the td elements (<td class="diff-deletedline diff-side-deleted"><div>Lorem ipsum ...</div></td>).

We would also need to to introduced a new variable to the method TableFormatter::printWordDiff to determine the value of a rowspan attribute for the td that is going to expand across different rows so that it allows the opposite side to print cell without having to worry about aligning to the other side. We would need to look ahead to see how many cells below the cell being printed are empty.

Event Timeline

HMonroy renamed this task from Update layout so that we can accommade the new design to Two Columns: Update layout so that we can accommade the new design.Feb 22 2023, 7:35 PM
HMonroy renamed this task from Two Columns: Update layout so that we can accommade the new design to Two Column: Update layout so that we can accommade the new design.
HMonroy set the point value for this task to 8.
HMonroy renamed this task from Two Column: Update layout so that we can accommade the new design to Two Column: Update layout so that we can accommodate the new design.Feb 23 2023, 12:52 AM
HMonroy updated the task description. (Show Details)
HMonroy updated the task description. (Show Details)
HMonroy renamed this task from Two Column: Update layout so that we can accommodate the new design to Two Column: Update layout to remove unnecessary white space in cells.Feb 23 2023, 4:33 PM

The engineering proposed layout looks really good and we should go ahead with that version (without the excess white space).

HMonroy removed a project: Community-Tech.