| bwang | |
| Feb 22 2023, 7:54 PM |
| F36865636: Screenshot 2023-02-22 at 1.54.40 PM.png | |
| Feb 22 2023, 7:54 PM |
| F36865635: IMG_5903.HEIC | |
| Feb 22 2023, 7:54 PM |
Currently the 'hide'/'move to sidebar' buttons in pinnable elements dont provide any context to screenreader users on what is being hidden or moved, its possible to have multiple buttons with the same label.
Instead we should use 'aria-label' on those buttons to read out 'Hide table of contents' or 'Move table of contents to sidebar'.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix accessibility: Add aria-labels to hide and move-to-sidebar buttons for menus | mediawiki/skins/Vector | master | +83 -24 |
Backlog Review Update: Needs to be reformatted into template, more detailed success criteria as well as testing instructions.
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
@Aklapper Thanks for the clarification. That was by mistake on my side and not intentional. I’ll make sure to be more careful with project tags in the future.
Change #1195743 had a related patch set uploaded (by Reszange; author: Reszange):
[mediawiki/skins/Vector@master] Fix accessibility: Add aria-labels to hide and move-to-sidebar buttons for menus (T330327).
I prepared some solution based on what was written about aria-labels in the task. I tested it with NVDA and Windows Narator. It works well for NVDA but Windows Narrator ignors the aria-labels and reads the button content. Maybe we should use something else - what do you think? I am not an expert and I had chosen this task mainly because of "good first task" tag. Here is my code (that would be my first contribution):
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1195743/1..2
I will add some reviewers after someone comments if we care about Windows Narrator.
I also have additional questions. Are there some reviewer groups I can enter in Gerrit?
Is it the right way to resolve conflicts:
git pull origin master git review -d 12345 git rebase master “fix conflicts” git add * git rebase –continue git review
Change #1195743 had a related patch set uploaded (by Jdlrobson; author: Reszange):
[mediawiki/skins/Vector@master] Fix accessibility: Add aria-labels to hide and move-to-sidebar buttons for menus
@Reszange thank you so much for submitting this patch and taking the time to look into this ticket! We've got a number of people out this week including one of our foremost ARIA experts, so there may be a bit of a delay in getting back to you about Windows Narrator/code review - rest assured we'll take a look soon, though!
Change #1195743 had a related patch set uploaded (by Reszange; author: Reszange):
[mediawiki/skins/Vector@master] Fix accessibility: Add aria-labels to hide and move-to-sidebar buttons for menus (T330327).
Change #1195743 had a related patch set uploaded (by Jdlrobson; author: Reszange):
[mediawiki/skins/Vector@master] Fix accessibility: Add aria-labels to hide and move-to-sidebar buttons for menus