PHP Warning: Invalid argument supplied for foreach()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Zabe
	Feb 22 2023, 8:22 PM

Description

Error

mwversion: 1.40.0-wmf.24
reqId: 975cf90e-52dd-45b9-a061-90aa0525d57c
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Warning: Invalid argument supplied for foreach()

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.24/extensions/CentralAuth/includes/GlobalRename/GlobalRenameDenylist.php(168)
#0 /srv/mediawiki/php-1.40.0-wmf.24/extensions/CentralAuth/includes/GlobalRename/GlobalRenameDenylist.php(168): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.24/extensions/CentralAuth/includes/Special/SpecialGlobalRenameUser.php(266): MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameDenylist->checkUser(string)
#2 /srv/mediawiki/php-1.40.0-wmf.24/extensions/CentralAuth/includes/Special/SpecialGlobalRenameUser.php(290): MediaWiki\Extension\CentralAuth\Special\SpecialGlobalRenameUser->validate(array)
#3 /srv/mediawiki/php-1.40.0-wmf.24/includes/htmlform/HTMLForm.php(742): MediaWiki\Extension\CentralAuth\Special\SpecialGlobalRenameUser->onSubmit(array, HTMLForm)
#4 /srv/mediawiki/php-1.40.0-wmf.24/includes/htmlform/HTMLForm.php(622): HTMLForm->trySubmit()
#5 /srv/mediawiki/php-1.40.0-wmf.24/includes/htmlform/HTMLForm.php(638): HTMLForm->tryAuthorizedSubmit()
#6 /srv/mediawiki/php-1.40.0-wmf.24/includes/specialpage/FormSpecialPage.php(224): HTMLForm->show()
#7 /srv/mediawiki/php-1.40.0-wmf.24/extensions/CentralAuth/includes/Special/SpecialGlobalRenameUser.php(103): FormSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-1.40.0-wmf.24/includes/specialpage/SpecialPage.php(700): MediaWiki\Extension\CentralAuth\Special\SpecialGlobalRenameUser->execute(NULL)
#9 /srv/mediawiki/php-1.40.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1463): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.40.0-wmf.24/includes/MediaWiki.php(324): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.40.0-wmf.24/includes/MediaWiki.php(917): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.40.0-wmf.24/includes/MediaWiki.php(573): MediaWiki->main()
#13 /srv/mediawiki/php-1.40.0-wmf.24/index.php(50): MediaWiki->run()
#14 /srv/mediawiki/php-1.40.0-wmf.24/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Impact

Notes

Details

MediaWiki Version: 1.40.0-wmf.24
Request URL: https://meta.wikimedia.org/wiki/Special:GlobalRenameUser

	Subject	Repo	Branch	Lines +/-
	Always initialize denyList in GlobalRenameDenylist::fetchList()	mediawiki/extensions/CentralAuth	master	+3 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T356502: PHP Warning: Invalid argument supplied for foreach()

Event Timeline

Zabe created this task.Feb 22 2023, 8:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2023, 8:22 PM

There should be a warning "GlobalRenameDenylist failed to fetch global rename denylist." in the log before this exception.

But it is not good to fail this way, when the list could not be fetched. Working without a list also is not correct.

thcipriani added a project: Unstewarded-production-error.Mar 9 2023, 4:54 PM

thcipriani moved this task from Untriaged to Mar 2023 on the Wikimedia-production-error board.

Umherirrender unsubscribed.Mar 13 2023, 7:55 PM

It comes from CentralAuth - I'm going to assign MediaWiki-Platform-Team as we're currently working on this extension.

larissagaulia moved this task from Inbox, needs triage to Backlog: non-prioritized on the MediaWiki-Platform-Team board.Nov 27 2023, 1:01 PM

Another example: https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2024.02.01?id=cgK5Zo0BW1B7XSkmk1bN

I'll drop this into the current sprint, we should not have PHP errors in production, and it's trivial to fix.

Change 995276 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@master] Always initialize denyList in GlobalRenameDenylist::fetchList()

https://gerrit.wikimedia.org/r/995276

gerritbot added a project: Patch-For-Review.Feb 2 2024, 5:53 PM

Change 995276 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Always initialize denyList in GlobalRenameDenylist::fetchList()

https://gerrit.wikimedia.org/r/995276

In T330332#9510103, @Tgr wrote:

I'll drop this into the current sprint, we should not have PHP errors in production, and it's trivial to fix.

Thanks!

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Feb 2 2024, 7:00 PM

pmiazga closed this task as Resolved.Feb 5 2024, 3:49 PM

pmiazga triaged this task as Medium priority.

PHP Warning: Invalid argument supplied for foreach()Closed, ResolvedPublicPRODUCTION ERRORActions