Page MenuHomePhabricator

[SW] [T-REF] [TECH] Remove Node14/16 fix from tainted references
Open, Needs TriagePublic

Description

Context
Recently, the Node-specific CI jobs were upgrade from Node 14 to Node 16 (see T314470), this caused Wikibase CI to fail for tainted references (see T330380), and a band-aid solution was applied (see Fix tainted-ref CI after Node v16 upgrade).
This is complicated by the fact that the jobs running the browser tests still are required to run Node 14, because the Selenium browser tests are written in the synchronous style, which no longer works with Node 16. There is one approach for refactoring those tests, see T300811, and one for reconsidering our stack for browser tests in general, see T180228 (given that we also still have ruby browser tests...).

Acceptance Criteria

  • the band-aid script added in extensions/Wikibase/+/891259 has been removed and everything works natively in Node16
  • double-checked that the test:distnodiff does work as expected (the above patch does not include a change to dist/, which is unintuitive)

Event Timeline

Michael changed the task status from Open to Stalled.Feb 23 2023, 12:22 PM

This needs browser tests to be solved first.

Change 946922 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Uninstall @wdio/sync and remove postinstall hack

https://gerrit.wikimedia.org/r/946922

Change 946922 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove node 16 incompatibility postinstall hack

https://gerrit.wikimedia.org/r/946922

Michael changed the task status from Stalled to Open.Aug 16 2023, 1:51 PM

The browser tests are currently not running and quibble has been updated to node 16. See T343886 for more on the browser tests.

ItamarWMDE renamed this task from Remove Node14/16 fix from tainted references to [SW] [T-REF] [TECH] Remove Node14/16 fix from tainted references.Sep 20 2023, 2:58 PM