Page MenuHomePhabricator
Create Task
Maniphest T330428

Validate SPDX licenses in foreign-resources.yaml using ForeignResourceManager/ForeignResourceStructureTest
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ForeignResourceManager: Add trailing newline in validateLicenseReedymediawiki/coreREL1_41+1 -1
ForeignResourceManager: Add trailing newline in validateLicenseReedymediawiki/coreREL1_40+1 -1
ForeignResourceManager: Add trailing newline in validateLicenseReedymediawiki/coremaster+1 -1
ResourceLoader: Check for valid SPDX license in ForeignResourceManagerReedymediawiki/coremaster+38 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Feb 23 2023, 8:12 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptFeb 23 2023, 8:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a subtask: T34892: Special:Version should include version numbers of JS resources like jQuery.Feb 23 2023, 8:13 PM
Reedy renamed this task from Validate SPDX licenses in foreign-resources.yaml to Validate SPDX licenses in foreign-resources.yaml using ForeignResourceManager.Feb 23 2023, 8:25 PM
Reedy closed subtask T34892: Special:Version should include version numbers of JS resources like jQuery as Resolved.
Reedy renamed this task from Validate SPDX licenses in foreign-resources.yaml using ForeignResourceManager to Validate SPDX licenses in foreign-resources.yaml using ForeignResourceManager/ForeignResourceStructureTest.Feb 23 2023, 8:50 PM
gerritbot added a comment.Feb 23 2023, 11:02 PM

Change 891708 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] ForeignResourceManager: Add license existence check and Spdx validation

https://gerrit.wikimedia.org/r/891708

gerritbot added a project: Patch-For-Review.Feb 23 2023, 11:02 PM
Reedy added a subtask: T330432: Update existing foreign-resources.yaml files to add extra fields.Feb 23 2023, 11:27 PM
Reedy closed subtask T330432: Update existing foreign-resources.yaml files to add extra fields as Resolved.Feb 24 2023, 4:28 PM
Reedy added a comment.Feb 24 2023, 4:31 PM

The existing foreign-resources.yaml files in extensions (ala T330432: Update existing foreign-resources.yaml files to add extra fields) have been updated, so merging the patch for this won't cause any failures when the various "MaintainForeignResources" maintenance scripts in them...

• larissagaulia moved this task from Inbox, needs triage to Radar on the Performance-Team board.Feb 27 2023, 8:01 PM
• larissagaulia edited projects, added: Performance-Team (Radar); removed: Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Feb 27 2023, 8:01 PM
gerritbot added a comment.Mar 1 2023, 9:49 PM

Change 891708 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Check for valid SPDX license in ForeignResourceManager

https://gerrit.wikimedia.org/r/891708

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Mar 1 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2023, 10:10 PM
Reedy closed this task as Resolved.Mar 1 2023, 10:48 PM
Reedy claimed this task.
Reedy mentioned this in T355005: VisualEditor's foreign-resources.yaml contains invalid SPDX license constructs.Jan 13 2024, 6:47 PM
gerritbot added a comment.Jan 13 2024, 7:06 PM

Change 990349 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] ForeignResourceManager: Add trailing newline in validateLicense

https://gerrit.wikimedia.org/r/990349

Restricted Application added a project: MediaWiki-Core-Platform-Team. · View Herald TranscriptJan 13 2024, 7:06 PM
gerritbot added a project: Patch-For-Review.Jan 13 2024, 7:06 PM
gerritbot added a comment.Jan 14 2024, 6:29 AM

Change 990349 merged by jenkins-bot:

[mediawiki/core@master] ForeignResourceManager: Add trailing newline in validateLicense

https://gerrit.wikimedia.org/r/990349

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2024, 6:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 14 2024, 7:00 AM
gerritbot added a comment.Jan 14 2024, 4:24 PM

Change 990408 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_40] ForeignResourceManager: Add trailing newline in validateLicense

https://gerrit.wikimedia.org/r/990408

gerritbot added a project: Patch-For-Review.Jan 14 2024, 4:24 PM

Change 990409 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_41] ForeignResourceManager: Add trailing newline in validateLicense

https://gerrit.wikimedia.org/r/990409

gerritbot added a comment.Jan 14 2024, 4:37 PM

Change 990409 merged by jenkins-bot:

[mediawiki/core@REL1_41] ForeignResourceManager: Add trailing newline in validateLicense

https://gerrit.wikimedia.org/r/990409

gerritbot added a comment.Jan 14 2024, 4:38 PM

Change 990408 merged by jenkins-bot:

[mediawiki/core@REL1_40] ForeignResourceManager: Add trailing newline in validateLicense

https://gerrit.wikimedia.org/r/990408

ReleaseTaggerBot edited projects, added: MW-1.41-notes, MW-1.40-notes; removed: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Jan 14 2024, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 14 2024, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits