Make the orchestrator emit an understandable error rather than have odd bugs when a non-implementation is supplied as the implementation to use
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	cmassaro
	Feb 23 2023, 8:16 PM

Description

In ApiPerformTestTest.php, there is a test called "Request specifies non-implementation as implementation, by reference." This test broke due to a notionally unrelated change in the orchestrator.

Because this test involves structural validation, we technically don't make any guarantees around it right now. We should do so in future, and we can make improvements to the orchestrator to make this specific case easier to reason about.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

comment out the offending test
catch obviously degenerate Z14s in the orchestrator (Implementation.create())
re-enable the test with updated expectations

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Subject	Repo	Branch	Lines +/-
ApiPerformTestTest: Re-enable test of passing a non-implementation.	mediawiki/extensions/WikiLambda	master	+1 -4
ApiPerformTestTest: Disable failing test of passing a non-implementation	mediawiki/extensions/WikiLambda	master	+19 -0
Return an error when the list of implementations contains something that is not a Z14.	mediawiki/services/function-orchestrator	master	+108 -2

Customize query in gerrit

Related Objects

Mentioned In: rMSFOaff8d26f28e2: Return an error when the list of implementations contains something that is not…

Event Timeline

cmassaro created this task.Feb 23 2023, 8:16 PM

Change 891618 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Test for when the list of implementations contains something that is not a Z14.

https://gerrit.wikimedia.org/r/891618

gerritbot added a project: Patch-For-Review.Feb 23 2023, 8:28 PM

Change 891622 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiPerformTestTest: Disable failing test of passing a non-implementation

https://gerrit.wikimedia.org/r/891622

Change 891618 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Return an error when the list of implementations contains something that is not a Z14.

https://gerrit.wikimedia.org/r/891618

cmassaro mentioned this in rMSFOaff8d26f28e2: Return an error when the list of implementations contains something that is not….Feb 23 2023, 8:47 PM

Change 891622 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiPerformTestTest: Disable failing test of passing a non-implementation

https://gerrit.wikimedia.org/r/891622

Change 891656 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiPerformTestTest: Re-enable test of passing a non-implementation

https://gerrit.wikimedia.org/r/891656

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 23 2023, 10:00 PM

Jdforrester-WMF renamed this task from Unreasonable bugs occur when something other than an implementation is supplied in place of an implementation to Make the orchestrator emit an understandable error rather than have odd bugs when a non-implementation is supplied as the implementation to use.Mar 7 2023, 6:54 PM

Jdforrester-WMF changed the subtype of this task from "Task" to "Bug Report".

DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Mar 7 2023, 7:36 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready: G2. Correct & efficient on the Abstract Wikipedia team (Phase θ – Throttling) board.Mar 7 2023, 7:36 PM

Change 891656 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiPerformTestTest: Re-enable test of passing a non-implementation.

https://gerrit.wikimedia.org/r/891656

Jdforrester-WMF closed this task as Resolved.Mar 9 2023, 7:47 PM

Jdforrester-WMF assigned this task to cmassaro.

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2023, 8:10 PM

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Mar 9 2023, 11:00 PM