Page MenuHomePhabricator
Create Task
Maniphest T330499

Deprecated: Creation of dynamic property MediaWiki\Minerva\Skins\SkinMinerva::$growthExperimentsHomepageDiscoveryNoticeSeen is deprecated includes/Homepage/SiteNoticeGenerator.php
Closed, ResolvedPublic
Actions

Description

Deprecated: Creation of dynamic property MediaWiki\Minerva\Skins\SkinMinerva::$growthExperimentsHomepageDiscoveryNoticeSeen is deprecated in /extensions/GrowthExperiments/includes/Homepage/SiteNoticeGenerator.php on line 171

Seen on PHP 8.2 in MobileFrontend.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not store state on another extension's objectmediawiki/extensions/GrowthExperimentsmaster+8 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Feb 24 2023, 1:25 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 24 2023, 1:25 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
kostajh added a parent task: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Feb 24 2023, 1:25 PM
kostajh added a project: Essential-Work.
kostajh added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated.Feb 24 2023, 1:29 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.2 support board.Feb 25 2023, 12:49 AM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Feb 27 2023, 1:02 AM
Tgr subscribed.

We should probably just turn SiteNoticeGenerator into a service so it can use its own property.

Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 27 2023, 1:02 AM
kostajh triaged this task as Medium priority.Feb 28 2023, 1:43 PM
gerritbot added a comment.Mar 8 2023, 7:05 AM

Change 895528 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Do not store state on another extension's object

https://gerrit.wikimedia.org/r/895528

gerritbot added a project: Patch-For-Review.Mar 8 2023, 7:05 AM
Tgr claimed this task.Mar 8 2023, 7:05 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 9 2023, 2:06 PM
kostajh added a subscriber: Etonkovidova.

@Etonkovidova can you please QA this one before it is in production next week? Thank you in advance!

gerritbot added a comment.Mar 9 2023, 2:27 PM

Change 895528 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Do not store state on another extension's object

https://gerrit.wikimedia.org/r/895528

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2023, 2:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 9 2023, 10:01 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 15 2023, 6:54 PM
Etonkovidova closed this task as Resolved.Mar 21 2023, 9:21 PM
In T330499#8679832, @kostajh wrote:

@Etonkovidova can you please QA this one before it is in production next week? Thank you in advance!

Sorry, missed the comment. Checked in wmf.27 and testwiki wmf.1 - the fix seems to be in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits