Page MenuHomePhabricator
Create Task
Maniphest T330517

IP masking: IP masked users cannot disable page previews
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Become an IP masked user (see T326911)
  • Hover over a page preview
  • Click the settings cog

What happens?:
You are redirected to the login page, as IP masked users are treated as registered users and IP masked users are prohibited from having preferences.

What should have happened instead?:
We should store the preference like we do for anonymous users.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Other Assignee
Jdlrobson
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
IP masked users use localStorage for settingsJdlrobsonmediawiki/extensions/Popupsmaster+35 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Feb 24 2023, 5:36 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptFeb 24 2023, 5:36 PM
Jdlrobson mentioned this in T326911: Update Web Team-owned products that may be affected by IP Masking.Feb 24 2023, 5:43 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.Feb 27 2023, 7:50 PM
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog-Archived board.Mar 1 2023, 11:09 PM
ovasileva added a parent task: T335440: [EPIC] Web team support for IP masking.Apr 26 2023, 5:39 PM
Jdlrobson moved this task from Current Fiscal Year to Web Team FY2022-23 Q4 Sprint 5 on the Web-Team-Backlog-Archived board.Apr 27 2023, 6:51 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5); removed: Web-Team-Backlog-Archived.
ovasileva triaged this task as Medium priority.May 3 2023, 5:42 PM
KSarabia-WMF set the point value for this task to 2.May 3 2023, 5:49 PM
LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 5 2023, 5:29 PM
Jdlrobson claimed this task.Jun 8 2023, 2:33 PM
Jdlrobson mentioned this in T337776: Prevent Popups from setting preferences for temporary accounts.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.
Jdlrobson updated Other Assignee, added: KSarabia-WMF.Jun 12 2023, 5:22 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 12 2023, 6:39 PM
gerritbot added a comment.Jun 12 2023, 6:40 PM

Change 929398 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] IP masked users use localStorage for settings

https://gerrit.wikimedia.org/r/929398

gerritbot added a project: Patch-For-Review.Jun 12 2023, 6:40 PM
Jdlrobson reassigned this task from Jdlrobson to KSarabia-WMF.Jun 12 2023, 6:40 PM
Jdlrobson updated Other Assignee, added: Jdlrobson; removed: KSarabia-WMF.
gerritbot added a comment.Jun 14 2023, 3:30 PM

Change 929398 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] IP masked users use localStorage for settings

https://gerrit.wikimedia.org/r/929398

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 4:10 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.Jun 14 2023, 5:42 PM
Jdlrobson reassigned this task from KSarabia-WMF to Edtadros.Jun 14 2023, 8:17 PM
Jdlrobson added subscribers: Edtadros, KSarabia-WMF.

@Edtadros we can QA this and other IP masking changes together. I'll setup a patchdemo URL when we are ready to do that.

Jdlrobson mentioned this in T339380: QA IP masking feature in Web team products.Jun 16 2023, 6:06 PM
Jdlrobson closed this task as Resolved.Jun 16 2023, 6:10 PM
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived ( Web Team FY2022-23 Q4 Sprint 5) board.

QA will be done in T339380

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits