Page MenuHomePhabricator

[IP masking] The watchstar shows in the Minerva skin
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Become an IP masked user
  • Visit any article page

What happens?:
A non functional watch star shows

Screen Shot 2023-02-24 at 9.50.37 AM.png (484×1 px, 85 KB)

What should have happened instead?:
It should should trigger the login workflow (Drawer) when clicked.

Screenshot 2023-06-01 at 1.19.48 PM.png (600×497 px, 64 KB)

Developer notes

This happens because of technical debt: Minerva uses its own menu system rather than relying on the behaviour in core.

QA Results - Beta (Patchdemo)

ACStatusDetails
1T330518#8966040

Event Timeline

Jdlrobson triaged this task as Medium priority.May 25 2023, 6:50 PM
LGoto set the point value for this task to 3.Jun 1 2023, 5:22 PM
Jdrewniak removed the point value for this task.
LGoto set the point value for this task to 3.Jun 1 2023, 5:23 PM

Change 930266 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Prompt IP masked users to login/create account when watchstar clicked

https://gerrit.wikimedia.org/r/930266

Jdlrobson updated Other Assignee, added: Jdlrobson.

Change 930266 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Prompt IP masked users to login/create account when watchstar clicked

https://gerrit.wikimedia.org/r/930266

Change 931701 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Resources: IP masked users cannot watch articles

https://gerrit.wikimedia.org/r/931701

Change 931701 merged by jenkins-bot:

[mediawiki/core@master] Resources: IP masked users cannot watch articles

https://gerrit.wikimedia.org/r/931701

Test Result - Beta

Status:
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Become an IP masked user
Visit any article page
❌ AC1: It should should trigger the login workflow (Drawer) when clicked.
The Login drawer does not appear.

Screen Recording 2023-06-24 at 5.51.11 PM.mov.gif (958×1 px, 327 KB)

Screen Recording 2023-06-24 at 5.53.27 PM.mov.gif (958×1 px, 497 KB)

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/85335bf21d/w

Edtadros removed Edtadros as the assignee of this task.EditedJun 26 2023, 11:24 PM

Test Result - Beta (Patchdemo)

Status: ✅ PASS
Environment: Patchdemo
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Perform these steps on https://patchdemo.wmflabs.org/wikis/85335bf21d/wiki/Main_Page
Become an IP masked user
Visit any article page
✅ AC1: It should should trigger the login workflow (Drawer) when clicked.

Screen Recording 2023-06-26 at 4.21.30 PM.mov.gif (1×1 px, 431 KB)

Jdlrobson claimed this task.

Thanks Edward! Skipping production QA since we can't do that right now.

Change 933493 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Mark mediawiki.user as a dependency to mediawiki.page.watch.ajax

https://gerrit.wikimedia.org/r/933493

Change 933493 merged by jenkins-bot:

[mediawiki/core@master] Mark mediawiki.user as a dependency to mediawiki.page.watch.ajax

https://gerrit.wikimedia.org/r/933493