Page MenuHomePhabricator
Create Task
Maniphest T330526

str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated (via HTMLUsersMultiselectField)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Install Echo with $wgEchoPerUserBlacklist = true;
  • Visit Special:Preferences

What happens?:

Deprecated:  str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in includes\WebRequest.php on line 539

Backtrace:

from includes\WebRequest.php(539)
#0 includes\htmlform\fields\HTMLUsersMultiselectField.php(23): WebRequest->getText(string, NULL)
#1 includes\htmlform\HTMLForm.php(2078): HTMLUsersMultiselectField->loadDataFromRequest(WebRequest)
#2 includes\htmlform\HTMLForm.php(585): HTMLForm->loadFieldData()
#3 includes\htmlform\HTMLForm.php(637): HTMLForm->prepareForm()
#4 includes\specials\SpecialPreferences.php(121): HTMLForm->show()
#5 includes\specialpage\SpecialPage.php(700): SpecialPreferences->execute(NULL)

What should have happened instead?:
No deprecation message is shown

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hooks: Set defaults for user blacklist preferencesmediawiki/extensions/Echomaster+3 -1
htmlform: Handle null from HTMLFormField::getDefault in multiselectsmediawiki/coreREL1_39+4 -4
htmlform: Handle null from HTMLFormField::getDefault in multiselectsmediawiki/coreREL1_38+4 -4
htmlform: Handle null from HTMLFormField::getDefault in multiselectsmediawiki/coreREL1_35+3 -3
htmlform: Handle null from HTMLFormField::getDefault in multiselectsmediawiki/coremaster+4 -4
Customize query in gerrit

Event Timeline

Umherirrender created this task.Feb 24 2023, 8:18 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 24 2023, 8:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender moved this task from Backlog to Wikimedia production on the PHP 8.2 support board.Feb 24 2023, 8:19 PM
gerritbot added a comment.Feb 25 2023, 12:49 AM

Change 891869 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Echo@master] Hooks: Set defaults for user blacklist preferences

https://gerrit.wikimedia.org/r/891869

gerritbot added a project: Patch-For-Review.Feb 25 2023, 12:49 AM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Feb 25 2023, 12:49 AM
Umherirrender added a comment.Feb 25 2023, 8:01 PM

Also happen when setting $wgEnableUserEmailMuteList = true; (may be needs some other settings to enable email at all locally)

gerritbot added a comment.Feb 25 2023, 8:08 PM

Change 891959 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/891959

gerritbot added a comment.Feb 26 2023, 6:55 PM

Change 891959 merged by jenkins-bot:

[mediawiki/core@master] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/891959

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 26 2023, 7:00 PM
• Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Feb 27 2023, 1:07 AM
• Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Mar 1 2023, 6:59 PM

Change 893546 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_39] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/893546

gerritbot added a comment.Mar 1 2023, 6:59 PM

Change 893547 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_38] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/893547

gerritbot added a comment.Mar 1 2023, 7:01 PM

Change 893548 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_35] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/893548

gerritbot added a comment.Mar 1 2023, 7:21 PM

Change 893548 merged by jenkins-bot:

[mediawiki/core@REL1_35] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/893548

gerritbot added a comment.Mar 1 2023, 7:22 PM

Change 893547 merged by jenkins-bot:

[mediawiki/core@REL1_38] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/893547

gerritbot added a comment.Mar 1 2023, 7:23 PM

Change 893546 merged by jenkins-bot:

[mediawiki/core@REL1_39] htmlform: Handle null from HTMLFormField::getDefault in multiselects

https://gerrit.wikimedia.org/r/893546

Umherirrender closed this task as Resolved.Mar 1 2023, 7:47 PM
Umherirrender claimed this task.
gerritbot added a comment.Mar 1 2023, 7:49 PM

Change 891869 abandoned by Reedy:

[mediawiki/extensions/Echo@master] Hooks: Set defaults for user blacklist preferences

Reason:

https://gerrit.wikimedia.org/r/891869

ReleaseTaggerBot added projects: MW-1.35-notes, MW-1.38-notes, MW-1.39-notes.Mar 1 2023, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2023, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits