Page MenuHomePhabricator

Release new version of HTMLFormatter
Closed, ResolvedPublic

Description

Event Timeline

With the PHP version bump, I guess it should be version 4 - https://github.com/wikimedia/HtmlFormatter/compare/3.0.1...master

Just needs CHANGELOG.md updating before we can tag a release

With the PHP version bump, I guess it should be version 4 - https://github.com/wikimedia/HtmlFormatter/compare/3.0.1...master

And a major version is a good time to do other "breaking" changes - https://gerrit.wikimedia.org/r/c/HtmlFormatter/+/891905

Change 891915 had a related patch set uploaded (by Reedy; author: Reedy):

[HtmlFormatter@master] CHANGELOG: Prepare for 4.0.0

https://gerrit.wikimedia.org/r/891915

Change 891915 merged by jenkins-bot:

[HtmlFormatter@master] CHANGELOG: Prepare for 4.0.0

https://gerrit.wikimedia.org/r/891915

Change 892004 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/vendor@master] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.0

https://gerrit.wikimedia.org/r/892004

Change 892005 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.0

https://gerrit.wikimedia.org/r/892005

Change 892006 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MobileFrontend@master] MobileFormatter: Update parseItemsToRemove sig for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/892006

I'm not sure, but I think the MobileFrontend tests failures with <section are 'real' changed behaviour coming out of c04e7104d5ce050026f9eca59861f561fb43b3ac

I'm not sure, but I think the MobileFrontend tests failures with <section are 'real' changed behaviour coming out of c04e7104d5ce050026f9eca59861f561fb43b3ac

The variables on HtmlFormatter::parseSelector are by-reference, not sure if typehinting is good for by-reference

With the PHP version bump, I guess it should be version 4 - https://github.com/wikimedia/HtmlFormatter/compare/3.0.1...master

Just needs CHANGELOG.md updating before we can tag a release

I was under the impression that php version bump isn't considered a major version change in SemVer (?)

With the PHP version bump, I guess it should be version 4 - https://github.com/wikimedia/HtmlFormatter/compare/3.0.1...master

Just needs CHANGELOG.md updating before we can tag a release

I was under the impression that php version bump isn't considered a major version change in SemVer (?)

That's our policy; anything that requires action on downstream users is a breaking change.

Change 951493 had a related patch set uploaded (by Reedy; author: Reedy):

[HtmlFormatter@master] HtmlFormatter: Add #[\ReturnTypeWillChange] to ease migration

https://gerrit.wikimedia.org/r/951493

Change 951493 merged by jenkins-bot:

[HtmlFormatter@master] HtmlFormatter: Add #[\ReturnTypeWillChange] to ease migration

https://gerrit.wikimedia.org/r/951493

Change 951494 had a related patch set uploaded (by Reedy; author: Reedy):

[HtmlFormatter@master] HtmlFormatter: Add #[\ReturnTypeWillChange] to correct function to ease migration

https://gerrit.wikimedia.org/r/951494

Change 951495 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TextExtracts@master] ExtractFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951495

Change 951494 merged by jenkins-bot:

[HtmlFormatter@master] HtmlFormatter: Add #[\ReturnTypeWillChange] to more functions to ease migration

https://gerrit.wikimedia.org/r/951494

Change 892004 merged by Reedy:

[mediawiki/vendor@master] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/892004

Change 951495 merged by jenkins-bot:

[mediawiki/extensions/TextExtracts@master] ExtractFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951495

Change 892006 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MobileFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/892006

Change 892005 merged by jenkins-bot:

[mediawiki/core@master] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/892005

Change 951986 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/vendor@REL1_40] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951986

Change 951987 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/vendor@REL1_39] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951987

Change 951858 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/extensions/MobileFrontend@REL1_40] MobileFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951858

Change 951859 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/extensions/MobileFrontend@REL1_39] MobileFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951859

Change 951860 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TextExtracts@REL1_40] ExtractFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951860

Change 951861 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/TextExtracts@REL1_39] ExtractFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951861

Change 951862 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_40] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951862

Change 951863 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_39] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951863

Change 951986 merged by Reedy:

[mediawiki/vendor@REL1_40] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951986

Change 951987 merged by Reedy:

[mediawiki/vendor@REL1_39] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951987

Change 951863 merged by jenkins-bot:

[mediawiki/core@REL1_39] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951863

Change 951862 merged by jenkins-bot:

[mediawiki/core@REL1_40] Upgrade wikimedia/html-formatter from 3.0.1 to 4.0.3

https://gerrit.wikimedia.org/r/951862

Change 951861 merged by jenkins-bot:

[mediawiki/extensions/TextExtracts@REL1_39] ExtractFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951861

Change 951860 merged by jenkins-bot:

[mediawiki/extensions/TextExtracts@REL1_40] ExtractFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951860

Change 951858 merged by Krinkle:

[mediawiki/extensions/MobileFrontend@REL1_40] MobileFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951858

Change 951859 merged by Reedy:

[mediawiki/extensions/MobileFrontend@REL1_39] MobileFormatter: Update for HtmlFormatter 4.0.0

https://gerrit.wikimedia.org/r/951859