Page MenuHomePhabricator

Don't show invitation to translate for a new article when previewing contents
Closed, ResolvedPublicBUG REPORT

Description

When creating a new article, Content Translation shows in some cases a suggestion for an article to be translated instead (T216500). Users of the wikitext editor that are not interested in translating can opt-out. However, every time they use the "Preview" option to check their changes, the pop-up appears again.

This ticket proposes to avoid showing the popup when the "Preview" functionality is used since it indicates the user is committed to create the content from scratch, and showing the same suggestion again and again is not useful.

The video below uses this page to illustrate the issue:

Steps to replicate the issue (include links if applicable):

  • Start a new article on yuewiki
  • When translation popup appears, dismiss it by clicking the close button
  • Press the preview button

What happens?:
The translation popup appears again even though it was dismissed

What should have happened instead?:
It should not reappear. This is a new behaviour that’s inconsistent with behaviouir from just a couple of days ago, and it is very distracting.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Hi @Al12si, thanks for taking the time to report this! Please always include full specific links, and a clear list of steps to reproduce - when exactly does some translation popup appear and what does it say?

Hi @Al12si, thanks for taking the time to report this! Please always include full specific links, and a clear list of steps to reproduce - when exactly does some translation popup appear and what does it say?

I thought Mediawiki would only produce one kind of translation popup. It says (completely in English):

Start with a translation instead?
Create a new article by translating from another language you know.
[snippet of article on other wiki]
[search icon] Find another page to translate [\hfill setup icon]

This does look different from the previous popup that I used to see, which was in Cantonese, at the top, and could be correctly dismissed. The new one is at the bottom (fixed positioning) so it’s very intrusive because it blocks the edit preview.

There are two versions of the popup depending on whether the translaiton tool is provided for the specific wiki as a beta feature or by default. We are in the process of graduating the tool out of beta, so there will be only one version of it. There is also a related (T290317) ticket to provide more options for disabling contribution prompts.

Considering all the above, I think we can set the focus of the ticket to the specific issue with the interaction: the "Preview" option should not result in the display of the suggestion. In this context, it doe snot make sense to propose an alternative way to contribute since the user using the option to preview the contents seems already committed in the direction to create the contents in the current editor. I'll update the ticket description with additional details. Thanks!

Pginer-WMF renamed this task from Cannot dismiss translation popup on yuewiki to Don't show invitation to translate for a new article when previewing contents.May 22 2023, 10:53 AM
Pginer-WMF triaged this task as Medium priority.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.

Change 931595 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Don't show invite to translate for new article when previewing contents

https://gerrit.wikimedia.org/r/931595

@Pginer-WMF should we hide the invitation even if the preview mode is on but no edit exists inside the editor?

@Pginer-WMF should we hide the invitation even if the preview mode is on but no edit exists inside the editor?

I'm inclined to hide the invitation in such case to keep the behaviour as simple as possible (i.e., no suggestions once you preview). If the implementation were more complex in such case, we could consider the alternative.

@Pginer-WMF should we hide the invitation even if the preview mode is on but no edit exists inside the editor?

@ngkountas I think the question Niklas was asking here is not exactly whether is an edit or not. In new article page, there is "Show Preview" button, and there is "Show Changes" button. "Show Changes" shows the diff. Niklas was asking about "Show Changes".

@Pginer-WMF should we hide the invitation even if the preview mode is on but no edit exists inside the editor?

@ngkountas I think the question Niklas was asking here is not exactly whether is an edit or not. In new article page, there is "Show Preview" button, and there is "Show Changes" button. "Show Changes" shows the diff. Niklas was asking about "Show Changes".

I think both cases (users checking the preview or their changes) are indicators of the user being in the process of making a contribution already, so it makes sense for both not to show the invite to translate.

Change 931595 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Don't show invite to translate for new article when previewing contents

https://gerrit.wikimedia.org/r/931595