Page MenuHomePhabricator
Create Task
Maniphest T330648

Vector 2022: Table of contents intersection observer doesn't account for browser scaling (uses pixels)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • open Firefox and zoom via the browser, for exemple at 120%
  • open a random page on a wiki with Vector 2022 skin, for exemple this one
  • scroll down

What happens?:

  • the active section of the content doesn't match the highlighted section of the TOC

What should have happened instead?:

  • the highlighted section in the TOC should be the active one

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
(reported by a user on MediaWiki)
configuration of the user: firefox-esr 102.8.0esr, Debian 11, screen resolution 1920x1200

tested also with Chrome Version 110.0.5481.105 (Build officiel) (64 bits) and Firefox version 110 (64 bits), Windows 10 Home, screen resolution 2560x1440, same result

Related Objects

Event Timeline

Una_tantum created this task.Feb 27 2023, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2023, 11:27 AM
Una_tantum updated the task description. (Show Details)Feb 27 2023, 11:31 AM
Una_tantum updated the task description. (Show Details)Feb 27 2023, 11:47 AM
Reedy added a project: Browser-Support-Firefox.Feb 27 2023, 12:49 PM
Una_tantum added a project: Accessibility.Feb 27 2023, 2:40 PM
Una_tantum updated the task description. (Show Details)Feb 27 2023, 2:49 PM
Una_tantum added a comment.Feb 27 2023, 2:59 PM

Probably related to https://phabricator.wikimedia.org/T317661 but perhaps this needs a specific solution

Jdlrobson renamed this task from Vector 2022: zooming in Firefox makes the ToC highlighting not fit to the text to Vector 2022: Table of contents intersection observer doesn't account for browser scaling (uses pixels).Feb 27 2023, 7:36 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.
Una_tantum added a project: Community Feedback (Reader).Mar 1 2023, 4:52 PM
ovasileva triaged this task as Medium priority.Mar 1 2023, 10:51 PM
ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog-Archived board.
• nray subscribed.Mar 3 2023, 12:04 AM

@Patafisik Thank you for the report. I tried replicating this on my Mac and Window (via Browserstack), but haven't been able to replicate this problem. Can you please check my recording at https://app.screencast.com/KfbS8Q0V1Uxay?conversation=2E9AB8aetLIJcobL533a0s, and let me know if I need to do something different to replicate it?

Patafisik_WMF subscribed.Mar 3 2023, 10:22 AM

@nray thank you for looking into this. Actually I can't reproduce it and I see the same thing you see, so I asked the user for a new feedback. However, if no technical changes have resolved this task meanwhile, T331109 may explain why both me and the user have had the impression of a mismatch.

Jdlrobson closed this task as Resolved.Mar 29 2023, 6:29 PM
Jdlrobson claimed this task.
Jdlrobson subscribed.

This is working for me as expected as well. Please feel free to reopen if something got missed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits