Page MenuHomePhabricator

Impact Module: don't show "Updated design" info drawer to new users
Closed, ResolvedPublicBUG REPORT

Description

Follow up fix for T323619: NewImpact: Introduce new design to existing newcomers via GuidedTour and Drawer.

User story

As a brand new user on mobile, I don't want to see the "updated design" info, because the information is not relevant to me.

As a user that hasn't edited (and only sees the Impact Module empty state), I don't want to see the "updated design" info, because the Impact Module empty state design change is minor and not relevant to me.

Steps to replicate the issue
  • Create a new account on mobile on a wiki where the new impact module is released
  • Navigate to the newcomer homepage
  • Navigate to "Your Impact"
What happens?

You receive the "Updated design" popup.
(Assuming you are in the New Impact experiment)

What should have happened instead?

You should NOT receive the "Updated design" popup.

Other information (browser name/version, screenshots, etc.)

You can check the behavior with this snippet in your browser console:

new mw.Api().saveOptions( { 'growthexperiments-tour-newimpact-discovery': 1 } );

On desktop, no "updated design" prompt appears, but on mobile, we show the "updated design" dialog after the user taps on the module.

Acceptance Criteria:

Given I've never edited (and thus see the impact module's empty state),
Then I should not see the "updated design" info drawer

Event Timeline

Showing the tour when growthexperiments-tour-newimpact-discovery is 0 is the expected behavior (and I can see it on both desktop and mobile with that setting). The code looks fine (we should probably set 0 as default for consistency, not false, but that won't affect new users since an explicit value is set for them) and I don't see the popup when I register a new account.

kostajh added a subscriber: Etonkovidova.

@KStoller-WMF I can't reproduce this on eswiki with a new user account that is in the control (a.k.a. new impact) group. @Etonkovidova, are you able to reproduce this?

@KStoller-WMF I can't reproduce this on eswiki with a new user account that is in the control (a.k.a. new impact) group. @Etonkovidova, are you able to reproduce this?

I was able to reproduce this when I go from an account created on eswiki to Special:Homepage on testwiki but that is expected; the code is written to account for users who are interacting with Impact module on their local wiki.

I'm admittedly testing via a rather odd flow:

  1. From my personal account created on English Wikipedia (on desktop / Safari), I visit: https://cs.m.wikipedia.org/
  2. Navigate to my newcomer homepage via the menu: https://cs.m.wikipedia.org/w/index.php?title=Speciáln%C3%AD:Domovská_stránka&namespace=0
  3. Tap into the New Impact module: https://cs.m.wikipedia.org/w/index.php?title=Speciáln%C3%AD:Domovská_stránka&namespace=0#/homepage/impact

I see the new impact module empty state + the info drawer:

Screenshot 2023-03-09 at 4.07.22 PM.png (1×1 px, 180 KB)

@KStoller-WMF I can't reproduce this on eswiki with a new user account that is in the control (a.k.a. new impact) group. @Etonkovidova, are you able to reproduce this?

Creating a new account on cswiki wmf.26 - the issue is not reproduced.
I saw the drawer before, for sure (even mentioned in some of my comments that the phrasing is not quite applicable).

I agree with @Tgr's comment - the behavior is logical, but for new users the drawers should not be shown.

We could just treat account autocreations the same way as account creations and set the seen flag, ie. never show the popup to users who first registered on a different wiki. There are some users who are new-ish and first registered on another wiki and have seen the old impact module (on this or another wiki) at some point, and conceptually we'd want to show the popup to those users, but that's niche problem and the behavior is never going to be perfect (we don't know who actually saw the old impact module in the past) so it's probably good enough?

Change 896322 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HomepageHooks: Set new impact discovery to seen for all created accounts

https://gerrit.wikimedia.org/r/896322

Change 896322 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HomepageHooks: Set new impact discovery to seen for all created accounts

https://gerrit.wikimedia.org/r/896322

This patch sets the tour as "seen" for all newly registered accounts, whether they are auto created or created local to the wiki, and whether or not they have homepage enabled. That should address the issue raised in this task.

This patch sets the tour as "seen" for all newly registered accounts, whether they are auto created or created local to the wiki, and whether or not they have homepage enabled. That should address the issue raised in this task.

Thanks, that sounds good to me!
I'm glad to hear this was more of an edge case for autocreated accounts; I originally thought it was impacting all newly created accounts on mobile.

Change 896322 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] TourHooks: Set new impact discovery to seen for all created accounts

https://gerrit.wikimedia.org/r/896322

Checked testwiki wmf.27 mobile - the "updated design" info drawer doesn't appear upon account creation. Also checked the desktop (for possible regression) - no issues were found.