| kostajh | |
| Feb 28 2023, 10:44 AM |
| F36875814: image.png | |
| Feb 28 2023, 10:44 AM |
Proposed label:
[label "All-Jobs-Passed"]
function = NoBlock
value = -1 Job failure
value = 0 No scoreThat would allow the Early warning bot to vote -1 for that label when a job fails:
Using the existing Verified label is not a good option, because a -1 will block a submit, and "recheck" on a flaky test would not automatically clear the vote from the earlywarningbot.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| gerrit: Add "All-Jobs-Passed" non-blocking label | operations/puppet | production | +5 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | kostajh | T323750 Provide early feedback when a patch has job failures | |||
| Declined | None | T330741 Create customized Gerrit label for "All-Jobs-Passed" |
Change 892922 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[operations/puppet@production] gerrit: Add "All-Jobs-Passed" non-blocking label
On second thought, it would be confusing to have this label always display, even for builds where no jobs failed. I think it will be more straightforward to educate developers about the workaround to manually remove "Verified: -1" when running "recheck".
Change 892922 abandoned by Kosta Harlan:
[operations/puppet@production] gerrit: Add "All-Jobs-Passed" non-blocking label
Reason:
T330741#8652111