Maniphest T330750

Quibble: Include the failed command in data passed to external endpoint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Feb 28 2023, 1:31 PM

Tags

Referenced Files

None

Subscribers

Description

With --reporting-url, Quibble will report on failed jobs to an external endpoint. Example https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/867531/7#message-62175eb34aaf14feb5ae25878d50f86a08cfa06e:

Failed job:
 "Run Post-dependency install, pre-database dependent steps in parallel (concurrency=3):
* PHPUnit unit tests
* Install MediaWiki, db=<MySQL /workspace/db/quibble-mysql-i8x5x6a7/socket> vendor=True
* npm install in /workspace/src"
See https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php74-docker/15192//consoleFull

That's sort of useful... but what the developer would probably want to know is that composer phpunit:unit -- --exclude-group Broken,ParserFuzz,Stub failed. We should be able to get this from the subprocess object.

Details

	Subject	Repo	Branch	Lines +/-
	jjb: update Quibble jobs to 1.5.1	integration/config	master	+23 -23
	dockerfiles: update to Quibble 1.5.1	integration/config	master	+55 -1
	release: Quibble 1.5.1	integration/quibble	master	+1 -1
	reporting: Include CalledProcessError.cmd in payload	integration/quibble	master	+21 -8

Customize query in gerrit

	Reference	Source Branch	Dest Branch	Author	Title
	kharlan/earlywarningbot!2	T330750	main	kharlan	build_info: Use "phase" in the output for gerrit comment

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kostajh	T323750 Provide early feedback when a patch has job failures
		Resolved		kostajh	T330750 Quibble: Include the failed command in data passed to external endpoint

Event Timeline

kostajh created this task.Feb 28 2023, 1:31 PM

Change 893016 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] reporting: Include CalledProcessError.cmd in payload

https://gerrit.wikimedia.org/r/893016

gerritbot added a project: Patch-For-Review.Feb 28 2023, 4:24 PM

kostajh claimed this task.Feb 28 2023, 4:24 PM

kharlan opened https://gitlab.wikimedia.org/kharlan/earlywarningbot/-/merge_requests/2

build_info: Use "phase" in the output for gerrit comment

Change 893016 merged by jenkins-bot:

[integration/quibble@master] reporting: Include CalledProcessError.cmd in payload

https://gerrit.wikimedia.org/r/893016

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2023, 10:31 AM

Change 893516 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] release: Quibble 1.5.1

https://gerrit.wikimedia.org/r/893516

gerritbot added a project: Patch-For-Review.Mar 1 2023, 5:39 PM

Change 893516 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.5.1

https://gerrit.wikimedia.org/r/893516

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2023, 6:31 PM

Mentioned in SAL (#wikimedia-releng) [2023-03-01T19:17:01Z] <hashar> Tagged Quibble 1.5.1 @ 9a163094a855 # T330750

Change 893528 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: update to Quibble 1.5.1

https://gerrit.wikimedia.org/r/893528

gerritbot added a project: Patch-For-Review.Mar 1 2023, 7:21 PM

Change 893528 merged by jenkins-bot:

[integration/config@master] dockerfiles: update to Quibble 1.5.1

https://gerrit.wikimedia.org/r/893528

kharlan merged https://gitlab.wikimedia.org/kharlan/earlywarningbot/-/merge_requests/2

build_info: Use "phase" in the output for gerrit comment

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2023, 8:10 PM

Change 893715 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update Quibble jobs to 1.5.1

https://gerrit.wikimedia.org/r/893715

Change 893715 merged by jenkins-bot:

[integration/config@master] jjb: update Quibble jobs to 1.5.1

https://gerrit.wikimedia.org/r/893715

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2023, 1:10 PM

kostajh closed this task as Resolved.Mar 14 2023, 12:52 PM