Page MenuHomePhabricator

[Epic] Temporary users should not be assigned to user groups
Closed, ResolvedPublic

Description

Motivation

For the MVP, we should disallow temporary users to be assigned into user-groups. We want to keep the temporary user experience close to the current experience for unregistered editors to avoid making drastic changes that may have unintended consequences for our editors and communities.

Spec:
  • Temporary users should not be allowed to be assigned user groups. The interface and behavior should be same as current behavior for IP addresses.

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenTchanders
OpenNone
ResolvedSTran
ResolvedUmherirrender
Resolved AGueyte
Duplicate AGueyte
ResolvedSTran
ResolvedDreamy_Jazz
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenSTran
OpenNone
OpenNone
OpenNone
OpenSTran
ResolvedSTran
ResolvedBUG REPORTDreamy_Jazz
OpenNone
Resolved TThoabala
Resolved TThoabala
Resolved TThoabala
Resolved AGueyte
ResolvedBUG REPORT AGueyte
ResolvedBUG REPORT AGueyte
Resolved AGueyte
Resolved AGueyte
ResolvedCyndymediawiksim
DuplicateNone
OpenNone
ResolvedTchanders
ResolvedTchanders
Resolved AGueyte
ResolvedTchanders
ResolvedTchanders
Resolved AGueyte
Resolved TThoabala
Resolved AGueyte
ResolvedNone
Resolved TThoabala
Resolved TThoabala
Resolvedabi_
Resolved TThoabala
Resolved TThoabala
Invalid TThoabala
ResolvedNone
ResolvedTchanders

Event Timeline

Change 932292 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Add temporary users to a 'temp' group, and stop adding them to 'user'

https://gerrit.wikimedia.org/r/932292

What needs doing?

Temp/user/named groups:

  • In UserGroupManager::getUserImplicitGroups, add temporary users to a 'temp' group, and stop adding them to the 'user' group
  • Keep 'named' group as future-proofing for if temp users do get the 'user' group

User rights:

  • Throw an error from Special:Userrights explaining that temporary users do not have groups

Autoconfimred and autopromote:

  • Prevent temp users from being reported as belonging to autopromote and autopromote-once groups (they already aren't if checking via PermissionManager)

UserGroupManager:

  • Throw an error for UserGroupManager::addUserToGroup if user is temp
  • Check if any other parts of UserGroupManager need updating to early return for temp, or whether these are safe to leave as is
  • Ensure UserGroupManager::addUserToGroup is not called on temporary users from WMF deployed code
  • Check that User::addGroup (deprecated, replaced by UserGroupManager::addUserToGroup) is not called on temporary users from WMF deployed code

Documentation:

Tchanders removed a project: Patch-For-Review.

This is ticket is tracking the subtasks, so moving to blocked/stalled while we work on those.

Niharika renamed this task from Temporary users should not be assigned to user groups to [Epic] Temporary users should not be assigned to user groups.Jun 30 2023, 8:25 PM
Niharika added a project: Epic.