Page MenuHomePhabricator

[M] Cannot read properties of null (reading 'offsetTop')
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

This issue has been recorded on logstash https://logstash.wikimedia.org/app/dashboards#/view/d67bb230-b779-11ed-8337-ade88c1fa820?_g=h@d942f56&_a=h@4c5d69e https://logstash.wikimedia.org/app/dashboards#/view/d67bb230-b779-11ed-8337-ade88c1fa820?_g=h@d942f56&_a=h@ad5c4b8)

What happens?:

  • The app is throwing an error when trying to fetch the offset top. This is needed on desktop to apply the correct dynamic space on the top.

What should have happened instead?:

  • If pageContainer is not available the app should have failed gracefully

Callstack Info:
This error is triggered both by the scrollY Handler and dynamicTop in AppVieDesktop.vue

Event Timeline

CBogen renamed this task from Cannot read properties of null (reading 'offsetTop') to [M] Cannot read properties of null (reading 'offsetTop').Mar 8 2023, 5:51 PM

Note: This ticket is extremely difficult to replicate. I would say that the expected QA is that nothing breaks after the change (mainly in the positioning of the search Preview), I will then follow up by checking logstash

Change 901565 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Cannot read properties of null (reading 'offsetTop')

https://gerrit.wikimedia.org/r/901565

Change 901565 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Cannot read properties of null (reading 'offsetTop')

https://gerrit.wikimedia.org/r/901565

Etonkovidova subscribed.

Note: This ticket is extremely difficult to replicate. I would say that the expected QA is that nothing breaks after the change (mainly in the positioning of the search Preview), I will then follow up by checking logstash

Thank you, @SimoneThisDot! I checked around for possible regressions - no issues; I'll also check for "Cannot read properties of null (reading 'offsetTop')" after wmf.3 deployment. The last week 99 such errors were recorded in logstash.

Checked wmf.3 - no errors (see logstash for error_context.version:"1.41.0-wmf.3". The last error timestamp Apr 6, 2023 @ 05:23:16.126.

The search Preview looks/behaves as expected (no Vue warnings/errors in the Console).