Page MenuHomePhabricator

Remove $wgGEHelpPanelLoggingEnabled configuration flag
Closed, ResolvedPublic

Description

$wgGEHelpPanelLoggingEnabled was a feature flag for when EventLogging was initially added to the help panel (T211942: Help panel: code for instrumentation); it hasn't been used since. It needs to be passed through to frontend code and adds to response sizes; we should remove it. (codesearch)

QA notes

Removing the enabling parameter touches all of the codepaths for help panel instrumentation. As part of QA for this task, we should ensure correct data is logged in help panel's instrumentation.

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedNone
OpenNone
ResolvedUrbanecm_WMF
OpenNone
OpenNone
ResolvedUrbanecm_WMF
OpenNone
OpenNone
ResolvedCyndymediawiksim
ResolvedNone
ResolvedTgr
In ProgressNone
Resolvedmatmarex
Resolvedkostajh
ResolvedUrbanecm_WMF
ResolvedUrbanecm_WMF
Resolvedkostajh

Event Timeline

Change 942371 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove $wgGEHelpPanelLoggingEnabled configuration flag

https://gerrit.wikimedia.org/r/942371

Urbanecm_WMF changed the task status from In Progress to Open.Aug 8 2023, 10:33 AM
Urbanecm_WMF updated the task description. (Show Details)

@Etonkovidova Please see QA notes in description (this patch has a chance of breaking the instrumentation content for help panel).

Change 942371 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove $wgGEHelpPanelLoggingEnabled configuration flag

https://gerrit.wikimedia.org/r/942371