Remove $wgGEHelpPanelLoggingEnabled configuration flag
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Mar 1 2023, 4:38 PM

Description

$wgGEHelpPanelLoggingEnabled was a feature flag for when EventLogging was initially added to the help panel (T211942: Help panel: code for instrumentation); it hasn't been used since. It needs to be passed through to frontend code and adds to response sizes; we should remove it. (codesearch)

QA notes

Removing the enabling parameter touches all of the codepaths for help panel instrumentation. As part of QA for this task, we should ensure correct data is logged in help panel's instrumentation.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove $wgGEHelpPanelLoggingEnabled configuration flag	mediawiki/extensions/GrowthExperiments	master	+12 -31

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Resolved	None	T340455 [Epic] Q1 FY 2023-24 Growth Maintenance Work
Open	None	T304538 Clean up GrowthExperiments-related user_properties rows
Resolved	Urbanecm_WMF	T304461 Delete `growthexperiments-mentor-id` properties from user_properties
Open	None	T304584 Implement alternate storage or retrieval for Recent Questions feature
Open	None	T304495 Implement database storage for Welcome Survey
Resolved	Urbanecm_WMF	T308309 Delete rows for growthexperiments-homepage-suggestededits-topics-enabled
Open	None	T308319 Remove growthexperiments-homepage-suggestededits-activated user property
Open	None	T332825 Remove growthexperiments-homepage-enable user property
Resolved	Cyndymediawiksim	T330910 Remove $wgGEHelpPanelLoggingEnabled configuration flag
Resolved	None	T333335 [Epic] Q4 FY 2022-23 Growth Maintenance Work
Resolved	Tgr	T322309 Create API module for image recommendation rejections
Resolved	kostajh	T328544 GrowthExperiments: Remove unnecessary target definitions
Resolved	Urbanecm_WMF	T321503 [structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist
Resolved	Urbanecm_WMF	T334928 linkrecommendation: Cron job should only run with eqiad deployment
Resolved	kostajh	T318523 Don't send article-linked notifications for bots

Event Timeline

Tgr created this task.Mar 1 2023, 4:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2023, 4:38 PM

Tgr triaged this task as Low priority.Mar 1 2023, 4:39 PM

Tgr moved this task from Incoming to Current Month Maintenance Priorities on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr updated the task description. (Show Details)Mar 1 2023, 4:41 PM

kostajh awarded a token.Mar 2 2023, 12:40 PM

kostajh added a parent task: T311850: [Epic] FY 2022-23 Growth Maintenance Work.

HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Mar 3 2023, 5:05 AM

DMburugu added a subtask: T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work.Apr 5 2023, 4:14 PM

DMburugu edited parent tasks, added: T340455: [Epic] Q1 FY 2023-24 Growth Maintenance Work, T340453: [Epic] FY 2023-24 Growth Maintenance Work; removed: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Jun 26 2023, 4:54 PM

Cyndymediawiksim claimed this task.Jul 24 2023, 12:27 PM

Cyndymediawiksim moved this task from Current Month Maintenance Priorities to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 27 2023, 8:20 AM

Change 942371 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove $wgGEHelpPanelLoggingEnabled configuration flag

https://gerrit.wikimedia.org/r/942371

gerritbot added a project: Patch-For-Review.Jul 27 2023, 9:16 AM

Cyndymediawiksim changed the task status from Open to In Progress.Jul 31 2023, 7:54 AM

Cyndymediawiksim moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

@Etonkovidova Please see QA notes in description (this patch has a chance of breaking the instrumentation content for help panel).

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 8 2023, 10:34 AM

Change 942371 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove $wgGEHelpPanelLoggingEnabled configuration flag

https://gerrit.wikimedia.org/r/942371

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2023, 12:30 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 8 2023, 1:00 PM

DMburugu closed subtask T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work as Resolved.Sep 25 2023, 11:58 AM

Etonkovidova closed this task as Resolved.Sep 26 2023, 10:37 PM

Remove $wgGEHelpPanelLoggingEnabled configuration flagClosed, ResolvedPublicActions