Page MenuHomePhabricator
Create Task
Maniphest T330934

[L] Send image suggestion notification (for article + section) to experienced users
Closed, ResolvedPublic
Actions

Description

This ticket covers the frequency and number for sending notifications. T330931 covers the notification UI.

This ticket builds up on the previously implemented similar ticket for article level notification T292147

  • Each user who has not opted out of these notifications with >500 edits (300 for PT) will get at most two notifications per week, one for each article. Each article may have several sub notifications (see T292147)
  • Turning off/on the existing "Image suggestions" preference in opt in/out settings enables/disables section level notifications as well as article level notifications
  • Do not exceed more than 5? subtype notifications at a time.
  • Suggestions should only be for articles on the user's watchlist
  • Suggestions should only be sent for articles with a confidence level >= 80% for article-level notifications
  • Suggestions should only be sent for articles with a confidence level >=TBD for section-level notifications
  • Unlike article-level notifications, for section-level if there are images for new sections in the article that becomes available then send the notification again for the same article. (moved to T337574)
  • Filter out P18-based section-level image suggestions (no longer necessary; see T330773)
  • For article level image suggestions, we filter out biographies (see T295369) but we will *not* filter out biographies for section-level suggestions
  • For a given unillustrated article, the article level image suggestion, if exists, is sent in a notification before or together with any potential section level image suggestions. (If an article level image suggestion does not exist for an unillustrated article, the section-level image suggestion should still be sent). For more context see T327933

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Section-level notificationsmediawiki/extensions/ImageSuggestionswmf/1.41.0-wmf.13+654 -142
Add section-level image suggestionsmediawiki/extensions/ImageSuggestionsmaster+282 -42
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sneha created this task.Mar 1 2023, 8:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2023, 8:15 PM
Sneha mentioned this in T330931: [L] Section Image suggestions notification UI.Mar 1 2023, 8:17 PM
Sneha added a parent task: T318017: [EPIC] Section-level Image Suggestions Notifications for More Experienced Contributors.
CBogen mentioned this in T330945: [S] Schedule section-level image suggestions notifications.Mar 1 2023, 8:59 PM
CBogen updated the task description. (Show Details)Mar 1 2023, 9:34 PM
CBogen updated the task description. (Show Details)Mar 2 2023, 2:17 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Mar 6 2023, 5:43 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
matthiasmullie mentioned this in T330905: Contributors can easily opt-out out of section image suggestion notifications.Mar 7 2023, 9:55 AM
matthiasmullie mentioned this in T330903: ECs do not receive notifications for p18-based image suggestions.Mar 7 2023, 9:59 AM
CBogen updated the task description. (Show Details)Mar 7 2023, 1:57 PM
CBogen merged a task: T330903: ECs do not receive notifications for p18-based image suggestions.
CBogen updated the task description. (Show Details)
CBogen added subscribers: • AUgolnikova-WMF, CBogen, matthiasmullie.
CBogen updated the task description. (Show Details)Mar 7 2023, 2:00 PM
CBogen merged a task: T330905: Contributors can easily opt-out out of section image suggestion notifications.
CBogen added a subtask: T327933: We prioritise article level over section level image suggestions for unillustrated articles in notifications for ECs.Mar 7 2023, 2:03 PM
CBogen updated the task description. (Show Details)
CBogen removed a subtask: T327933: We prioritise article level over section level image suggestions for unillustrated articles in notifications for ECs.
CBogen updated the task description. (Show Details)Mar 7 2023, 2:05 PM
• AUgolnikova-WMF updated the task description. (Show Details)Mar 7 2023, 4:25 PM
• AUgolnikova-WMF mentioned this in T327933: We prioritise article level over section level image suggestions for unillustrated articles in notifications for ECs.
CBogen updated the task description. (Show Details)Mar 7 2023, 4:46 PM
CBogen renamed this task from Send image suggestion notification (for article + section) to experienced users to [L] Send image suggestion notification (for article + section) to experienced users.Mar 22 2023, 4:42 PM
CBogen moved this task from Ready for Estimation to Blocked on the Structured-Data-Backlog (Current Work) board.Mar 22 2023, 5:07 PM
CBogen added a comment.Mar 22 2023, 5:12 PM

Blocked on initial version of the SLIS pipeline

CBogen updated the task description. (Show Details)Mar 23 2023, 2:13 PM
CBogen added a comment.Apr 3 2023, 4:27 PM

Blocked on T322872

Cparle claimed this task.May 11 2023, 10:16 AM
Cparle moved this task from Blocked to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.May 26 2023, 4:25 PM

Change 923663 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/ImageSuggestions@master] Add section-level image suggestions

https://gerrit.wikimedia.org/r/923663

gerritbot added a project: Patch-For-Review.May 26 2023, 4:25 PM
Cparle updated the task description. (Show Details)May 26 2023, 4:30 PM
Cparle updated the task description. (Show Details)
Cparle mentioned this in T337574: Don't filter image suggestions for a section if the user hasn't gotten a suggestion for that section before.
Cparle moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.May 29 2023, 4:24 PM
gerritbot added a comment.Jun 9 2023, 9:21 AM

Change 923663 abandoned by Cparle:

[mediawiki/extensions/ImageSuggestions@master] Add section-level image suggestions

Reason:

https://gerrit.wikimedia.org/r/923663

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2023, 9:30 AM
Cparle added a comment.Jun 9 2023, 2:34 PM

The patch for T330931 covers this too

gerritbot added a comment.Jun 26 2023, 10:54 AM

Change 933066 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ImageSuggestions@wmf/1.41.0-wmf.13] Section-level notifications

https://gerrit.wikimedia.org/r/933066

gerritbot added a project: Patch-For-Review.Jun 26 2023, 10:54 AM
gerritbot added a comment.Jun 26 2023, 1:52 PM

Change 933066 abandoned by Matthias Mullie:

[mediawiki/extensions/ImageSuggestions@wmf/1.41.0-wmf.13] Section-level notifications

Reason:

Not getting backported

https://gerrit.wikimedia.org/r/933066

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2023, 2:11 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jun 27 2023, 12:12 PM
matthiasmullie closed this task as Resolved.Jul 5 2023, 8:24 AM

This is done: section level suggestion notifications have been delivered successfully (except for fiwiki, tracked here: T341112)

Confirmed with these queries:

# Total suggestions:
SELECT COUNT(*) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND notification_timestamp > '20230705000000';

# Page suggestions:
SELECT COUNT(*) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND event_extra LIKE '%s:15:"section-heading";N%' AND notification_timestamp > '20230705000000';

# Section suggestions:
SELECT COUNT(*) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND event_extra LIKE '%s:15:"section-heading";s:%' AND notification_timestamp > '20230705000000';

# Distinct users:
SELECT COUNT(DISTINCT event_agent_id) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND notification_timestamp > '20230705000000';

# Notifications (individual or bundled):
SELECT COUNT(DISTINCT event_agent_id, event_page_id) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND notification_timestamp > '20230705000000';
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits