Page MenuHomePhabricator

[L] Send image suggestion notification (for article + section) to experienced users
Closed, ResolvedPublic

Description

This ticket covers the frequency and number for sending notifications. T330931 covers the notification UI.

This ticket builds up on the previously implemented similar ticket for article level notification T292147

  • Each user who has not opted out of these notifications with >500 edits (300 for PT) will get at most two notifications per week, one for each article. Each article may have several sub notifications (see T292147)
  • Turning off/on the existing "Image suggestions" preference in opt in/out settings enables/disables section level notifications as well as article level notifications
  • Do not exceed more than 5? subtype notifications at a time.
  • Suggestions should only be for articles on the user's watchlist
  • Suggestions should only be sent for articles with a confidence level >= 80% for article-level notifications
  • Suggestions should only be sent for articles with a confidence level >=TBD for section-level notifications
  • Unlike article-level notifications, for section-level if there are images for new sections in the article that becomes available then send the notification again for the same article. (moved to T337574)
  • Filter out P18-based section-level image suggestions (no longer necessary; see T330773)
  • For article level image suggestions, we filter out biographies (see T295369) but we will *not* filter out biographies for section-level suggestions
  • For a given unillustrated article, the article level image suggestion, if exists, is sent in a notification before or together with any potential section level image suggestions. (If an article level image suggestion does not exist for an unillustrated article, the section-level image suggestion should still be sent). For more context see T327933

Related Objects

Event Timeline

CBogen renamed this task from Send image suggestion notification (for article + section) to experienced users to [L] Send image suggestion notification (for article + section) to experienced users.Mar 22 2023, 4:42 PM

Blocked on initial version of the SLIS pipeline

Change 923663 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/ImageSuggestions@master] Add section-level image suggestions

https://gerrit.wikimedia.org/r/923663

Change 923663 abandoned by Cparle:

[mediawiki/extensions/ImageSuggestions@master] Add section-level image suggestions

Reason:

https://gerrit.wikimedia.org/r/923663

Change 933066 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ImageSuggestions@wmf/1.41.0-wmf.13] Section-level notifications

https://gerrit.wikimedia.org/r/933066

Change 933066 abandoned by Matthias Mullie:

[mediawiki/extensions/ImageSuggestions@wmf/1.41.0-wmf.13] Section-level notifications

Reason:

Not getting backported

https://gerrit.wikimedia.org/r/933066

This is done: section level suggestion notifications have been delivered successfully (except for fiwiki, tracked here: T341112)

Confirmed with these queries:

# Total suggestions:
SELECT COUNT(*) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND notification_timestamp > '20230705000000';

# Page suggestions:
SELECT COUNT(*) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND event_extra LIKE '%s:15:"section-heading";N%' AND notification_timestamp > '20230705000000';

# Section suggestions:
SELECT COUNT(*) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND event_extra LIKE '%s:15:"section-heading";s:%' AND notification_timestamp > '20230705000000';

# Distinct users:
SELECT COUNT(DISTINCT event_agent_id) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND notification_timestamp > '20230705000000';

# Notifications (individual or bundled):
SELECT COUNT(DISTINCT event_agent_id, event_page_id) FROM echo_event INNER JOIN echo_notification ON notification_event = event_id WHERE event_type = 'image-suggestions' AND notification_timestamp > '20230705000000';