Page MenuHomePhabricator

"Show IP" button shown in italics when temporary account username is deleted or suppressed
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Make a test edit using a temporary account
  • Log into an account that either can suppress or has the deleterevision right
  • Suppress or revision delete the temporary account username
  • Load Special:RevisionDelete for the revision with the hidden username

Can be reproduced on Special:MergeHistory too. Seems to only occur when the temporary account username that is revision deleted or suppressed is shown but with a strikethrough (so not on the history or contribution pages).

What happens?:
The "Show IP" button is shown in italic text.

Also when pressed the IP is struck through in the same way that the temporary account name is.

What should have happened instead?:
The button probably shouldn't be in italics.

Software version (skip for WMF-hosted wikis like Wikipedia):
Latest CheckUser and core code on local testing wiki

Other information (browser name/version, screenshots, etc.):
Screenshots of the issue (red arrows for clarity in case my description wasn't clear):

Username revision deletion statusWith buttonAfter pressing button
Not deleted (as expected)
image.png (115×1 px, 22 KB)
image.png (102×1 px, 22 KB)
Revision deleted
image.png (111×1 px, 26 KB)
image.png (123×1 px, 28 KB)
Suppressed
image.png (117×1 px, 23 KB)
image.png (130×1 px, 28 KB)

While the IP being struck through in the same way as the temporary account name may not be an issue, it could indicate that the IP revealed itself is either suppressed or revision deleted. However, the IP isn't deleted or suppressed in this case (only the temporary account username).

For Special:MergeHistory:

Username revision deletion statusWith buttonAfter pressing button
Suppressed
image.png (58×1 px, 19 KB)
image.png (61×1 px, 19 KB)

Testing Notes:

NB : You need to have the deleterevision or suppressrevision user right to perform these actions

For Special:RevisionDelete:

  • Go to the page history or log page where the temporary account username is shown.
  • Check the box next to the revision or log entry that you want to delete.
  • Click the Change visibility of selected revisions button at the top of the page.
  • Choose which parts of the revision or log entry you want to hide: the revision text, the edit summary, or the editor’s username/IP address.
  • Optionally, check the box to hide the information from administrators as well (if you have the suppressrevision right).
  • Enter a reason for hiding the information in the box provided.
  • Click Apply to selected revision(s).
  • Check that the 'Show IP' button and the revealed IP information font style is not italicised

For Special:MergeHistory:

  • Go to the Special: MergeHistory page
  • Enter the Source Page and Destination Page names
  • Click on Show Mergeable Edits button.
  • On the Mergeable edit history section check that the 'Show IP' button and the revealed IP information font style is not italicised

Event Timeline

Dreamy_Jazz renamed this task from "Show IP" button shown in italics on Special:RevisionDelete to "Show IP" button shown in italics when temporary account username is deleted or suppressed, but still shown.Mar 2 2023, 1:34 AM
Dreamy_Jazz renamed this task from "Show IP" button shown in italics when temporary account username is deleted or suppressed, but still shown to "Show IP" button shown in italics when temporary account username is deleted or suppressed.
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)

Also when I blocked a temporary account with "Hide username from edits and lists" checked, the two following Special pages also have this issue:

  • Special:ActiveUsers:

image.png (39×1 px, 19 KB)

image.png (93×1 px, 39 KB)

  • Special:ListUsers:

image.png (45×1 px, 20 KB)

image.png (100×1 px, 50 KB)

Dreamy_Jazz attached a referenced file: F36887626: image.png. (Show Details)

While the real-world use of having a temporary username deleted or suppressed for a revision is likely small, it may happen and ensuring parent element styles don't affect the button (such as italics) is likely to prevent other issues.

Change 914857 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/core@master] Restore normal font style in "Show IP" button in Special:RevisionDelete and Special:MergeHistory pages.

https://gerrit.wikimedia.org/r/914857

Change 917173 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/CheckUser@master] Restore normal font style in "Show IP" button in Special:RevisionDelete and Special:MergeHistory pages.

https://gerrit.wikimedia.org/r/917173

Change 914857 abandoned by Cyndywikime:

[mediawiki/core@master] Restore normal font style in "Show IP" button in Special:RevisionDelete and Special:MergeHistory pages.

Reason:

This change has been abandoned in favour of this one : https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/917173

https://gerrit.wikimedia.org/r/914857

Change 917173 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Restore normal font style in "Show IP" button in Special:RevisionDelete and Special:MergeHistory pages.

https://gerrit.wikimedia.org/r/917173

@Cyndymediawiksim The Show IP and IP addresses are not italicized as seen from the screenshots below. When it is suppressed or deleted, everything else is italicized, except Show IP button or when the IP address is revealed.

I also wanted to make sure when suppressed, it's a two lines cross out and when it's deleted, it's one line crossed out and the IP address turns to a light shade of grey.

I did come across an issue with the Minerva skin. Please let me know if you want me to create a new ticket for this or just leave it here. The issue is that *Unregistered 22 and *Unregistered 21 are not crossed out like the other skins. Only in Special:MergeHistory, not View History. It's still showing as unmarked. Also, there is no text bow surrounding the Source, Destination, etc. Thanks!

StatusSpecial:RevisionDeleteSpecial:MergeHistory
Surpressed
T330964_IPMasking_ShowIP_NotItalicised_SupressedHistory.png (483×1 px, 154 KB)
T330964_IPMasking_ShowIP_NotItalicised_SupressedMerge.png (630×3 px, 185 KB)
Delete
T330964_IPMasking_ShowIP_NotItalicised_DeleteHistory.png (509×1 px, 166 KB)
T330964_IPMasking_ShowIP_NotItalicised_DeleteMerge.png (655×3 px, 202 KB)

Special:MergeHistory- Temp users are not crossed out and have no text box outline

Minerva Skin
T330964_IPMasking_ShowIP_NotItalicised_MinervaHistory.png (758×1 px, 155 KB)
T330964_IPMasking_ShowIP_NotItalicised_MinervaMerge.png (1×1 px, 136 KB)