Page MenuHomePhabricator

Try new task: Don't show post-edit dialog toast message
Closed, ResolvedPublic

Description

If user the closes the try new task panel (close button; no thanks button; or "try new task" button), they'll see the post-edit toast message. That doesn't make sense; let's hide it.

trynewtask.gif (793×1 px, 680 KB)

Acceptance criteria

  • The success edit save message shows only once regardless of how many drawers are shown after edit
  • The success edit save message shows when the first post-edit drawer is displayed (Try new task drawer)

Event Timeline

Change 895752 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: avoid showing the toast success message twice

https://gerrit.wikimedia.org/r/895752

Sgs changed the task status from Open to In Progress.Mar 8 2023, 1:06 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 895752 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: avoid showing the toast success message twice

https://gerrit.wikimedia.org/r/895752

Etonkovidova subscribed.

Checked on testwiki wmf.2 - the toast message doesn't appear after interacting with the leveling post-edit dialog:

post_edit test6.gif (635×970 px, 2 MB)