Page MenuHomePhabricator

Search Preview: Arrow placed incorrect on mobile with small snippet
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

https://www.loom.com/share/2d9c9c7aa22447e4bb5007464968292f

What happens?:
The arrow moves when we open a Search PReview on mobiles if the snippet is NOT the expected 4 lines long.

What should have happened instead?:
The arrow should stay in the same position

NOTE: This change requires changes to the HTML and LOTS of testing, it is not a small piece of work!

Event Timeline

Further testing has alighted a new issue with the arrow, being introduced by the "expansion" of the snippets, that was moving the arrow.

Please note that the HTML received when the search result HAS content and the one received when the wiki does NOT have content are very different and both need to be tested.

The following scenario has been solved:

  • Default height
  • Short content
  • Expanded snippet

What has NOT been solved (this was agreed not to be solved as it is very unluckily to happen in production as it would mean that a result has no sections).

  • "No result found" This will just place the arrow at 58px from the top, to be well positioned in small and large results)

Change 924880 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Search Preview: Arrow placed incorrect on mobile with small snippet

https://gerrit.wikimedia.org/r/924880

Change 924880 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search Preview: Arrow placed incorrect on mobile with small snippet

https://gerrit.wikimedia.org/r/924880

Etonkovidova subscribed.

Checked in wmf.12 - works as expected.