Page MenuHomePhabricator

Remove selenium tests from portals/deploy repo
Closed, ResolvedPublicBUG REPORT


Recently, the Selenium tests in the portals/deploy repo have started failing with the following error:

10:09:35 > portals-deploy@1.0.0 selenium
10:09:35 > chromedriver --url-base=/wd/hub --port=4444 & trap 'pkill chromedriver' EXIT; ./node_modules/.bin/wdio ./tests/selenium/wdio.conf.js
10:09:35 node: ../src/ void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.
10:09:35 Aborted
10:09:35 Build step 'Execute shell' marked build as failure

This is due to this old version of not being supported by Node 16.

The tests that run are basically unmaintained and provide little value. They essentially just check for errors in the browser console.
This functionality can be replicated (in a production context) with the client-side error logging infrastructure we currently have available.

Therefore, instead of updating these tests, I think it makes more sense to delete them, which would also remove the entire Node & npm dependency from this repo (also moving T273785 forward).

Event Timeline

Change 894572 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[wikimedia/portals/deploy@master] Remove unmaintained selenium tests

Change 894572 merged by jenkins-bot:

[wikimedia/portals/deploy@master] Remove unmaintained selenium tests